Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: support isElement function #4041

Merged
merged 5 commits into from Aug 4, 2023
Merged

feature: support isElement function #4041

merged 5 commits into from Aug 4, 2023

Conversation

cbbfcd
Copy link
Contributor

@cbbfcd cbbfcd commented Jun 8, 2023

react-is support isElement function in new version

react-is supports the isElement method, so a minimal compatibility is made here

@cbbfcd
Copy link
Contributor Author

cbbfcd commented Jul 18, 2023

hi~ @developit , What do I need to do before this PR is merged in? thx~

JoviDeCroock
JoviDeCroock approved these changes Aug 4, 2023
View reviewed changes
compat/src/index.js Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 99.563%. remained the same when pulling 77c836b on cbbfcd:feature/support-is-element into d8f2fb3 on preactjs:main.

@JoviDeCroock JoviDeCroock merged commit 485320f into preactjs:main Aug 4, 2023
3 checks passed
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 12, 2023
Merged
@JoviDeCroock JoviDeCroock mentioned this pull request Apr 27, 2024
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cbbfcd @coveralls @developit @JoviDeCroock