Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing SvgProps and make the generics mandatory #4071

Merged
merged 3 commits into from Jul 17, 2023
Merged

add missing SvgProps and make the generics mandatory #4071

merged 3 commits into from Jul 17, 2023

Conversation

JoviDeCroock
Copy link
Member

@coveralls
Copy link

coveralls commented Jul 12, 2023 •
edited

Coverage Status

coverage: 99.561%. remained the same when pulling f08e4e1 on fix-react-compat-types into 34e37c5 on main.

marvinhagemeister
marvinhagemeister approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JoviDeCroock JoviDeCroock merged commit 5a56a83 into main Jul 17, 2023
2 checks passed
@JoviDeCroock JoviDeCroock deleted the fix-react-compat-types branch July 17, 2023 07:54
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 12, 2023
Merged
@JoviDeCroock JoviDeCroock mentioned this pull request Apr 27, 2024
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@rschristian rschristian rschristian approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing/incorrect React types (SVGProps, HTMLAttributes)
4 participants
@JoviDeCroock @coveralls @marvinhagemeister @rschristian