Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve place child #4172

Merged
merged 4 commits into from
Oct 28, 2023
Merged

Improve place child #4172

merged 4 commits into from
Oct 28, 2023

Commits on Oct 28, 2023

  1. Simplify placeChild 

    Remove impossible conditions
    @andrewiggins
    andrewiggins committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    08ac5ce View commit details
    Browse the repository at this point in the history

  2. Add some labels to test DOM to make debugging easier

    @andrewiggins
    andrewiggins committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    cb0858e View commit details
    Browse the repository at this point in the history

  3. Ensure oldDom is correctly bubbled up through _nextDom in unmounting … 

    …scenarios
    @andrewiggins
    andrewiggins committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    f1c4667 View commit details
    Browse the repository at this point in the history

  4. Further simplify placeChild with newly unnecessary conditions

    @andrewiggins
    andrewiggins committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    137da3c View commit details
    Browse the repository at this point in the history