Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComponentType to preact/compat #4239

Merged
merged 3 commits into from Dec 22, 2023
Merged

Conversation

ianobermiller
Copy link
Contributor

Add the ComponentType type that represents a class or function component with optional props to mirror the same type in @types/react: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/0818c3f7de545c6b6431e9745dd9910618bba918/types/react/index.d.ts#L43

Add the `ComponentType` type that represents a class or function component with optional props to mirror the same type in `@types/react`: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/0818c3f7de545c6b6431e9745dd9910618bba918/types/react/index.d.ts#L43
compat/src/index.d.ts Outdated Show resolved Hide resolved
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
compat/src/index.d.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 99.464%. remained the same
when pulling be2ca05 on ianobermiller:patch-1
into 4f2a04f on preactjs:main.

@rschristian rschristian merged commit f963509 into preactjs:main Dec 22, 2023
2 checks passed
@rschristian
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants