Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure we are able to support capture events from compat #4243

Merged
merged 2 commits into from
Jan 2, 2024
Merged

ensure we are able to support capture events from compat #4243

merged 2 commits into from
Jan 2, 2024

Conversation

JoviDeCroock
Copy link
Member

Resolves #4237

In compat we always lower-case our events, this prevents us from supporting events ending with Capture (which is our heuristic to make the events passive). We could stop doing this but the change would be a lot bigger as opposed to performing a case insensitive check.

One concern I have here would be custom-elements 😅

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 29, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +2% (-1.38ms - +1.33ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -2% - +5% (-0.66ms - +1.70ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -0% - +1% (-3.67ms - +7.38ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +0% (-0.03ms - +0.06ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-1.89ms - +0.99ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -1% - +2% (-0.09ms - +0.37ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -1% - +3% (-0.03ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.26ms - +0.24ms)
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -2% - +1% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main

Results

02_replace1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main83.27ms - 85.09ms-unsure 🔍
-2% - +2%
-1.33ms - +1.38ms		unsure 🔍
-1% - +2%
-1.04ms - +1.50ms
preact-local83.15ms - 85.16msunsure 🔍
-2% - +2%
-1.38ms - +1.33ms		-unsure 🔍
-1% - +2%
-1.14ms - +1.55ms
preact-hooks83.06ms - 84.84msunsure 🔍
-2% - +1%
-1.50ms - +1.04ms		unsure 🔍
-2% - +1%
-1.55ms - +1.14ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.32ms - 3.32ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.32ms - 3.32msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.03ms
preact-hooks3.34ms - 3.34msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
1% - 1%
0.02ms - 0.03ms		-

run-warmup-0

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main31.44ms - 32.78ms-unsure 🔍
-2% - +4%
-0.61ms - +1.15ms		unsure 🔍
-4% - +2%
-1.14ms - +0.73ms
preact-local31.26ms - 32.42msunsure 🔍
-4% - +2%
-1.15ms - +0.61ms		-unsure 🔍
-4% - +1%
-1.34ms - +0.39ms
preact-hooks31.67ms - 32.96msunsure 🔍
-2% - +4%
-0.73ms - +1.14ms		unsure 🔍
-1% - +4%
-0.39ms - +1.34ms		-

run-warmup-1

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main39.50ms - 41.04ms-unsure 🔍
-1% - +5%
-0.48ms - +1.80ms		unsure 🔍
-4% - +1%
-1.65ms - +0.26ms
preact-local38.77ms - 40.45msunsure 🔍
-4% - +1%
-1.80ms - +0.48ms		-faster ✔
1% - 6%
0.35ms - 2.37ms
preact-hooks40.41ms - 41.53msunsure 🔍
-1% - +4%
-0.26ms - +1.65ms		slower ❌
1% - 6%
0.35ms - 2.37ms		-

run-warmup-2

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main29.85ms - 31.03ms-unsure 🔍
-2% - +3%
-0.58ms - +0.98ms		unsure 🔍
-4% - +2%
-1.11ms - +0.49ms
preact-local29.73ms - 30.74msunsure 🔍
-3% - +2%
-0.98ms - +0.58ms		-unsure 🔍
-4% - +1%
-1.25ms - +0.23ms
preact-hooks30.20ms - 31.29msunsure 🔍
-2% - +4%
-0.49ms - +1.11ms		unsure 🔍
-1% - +4%
-0.23ms - +1.25ms		-

run-warmup-3

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main23.27ms - 23.99ms-unsure 🔍
-2% - +3%
-0.41ms - +0.61ms		unsure 🔍
-4% - +1%
-0.89ms - +0.22ms
preact-local23.17ms - 23.89msunsure 🔍
-3% - +2%
-0.61ms - +0.41ms		-unsure 🔍
-4% - +0%
-0.99ms - +0.13ms
preact-hooks23.54ms - 24.38msunsure 🔍
-1% - +4%
-0.22ms - +0.89ms		unsure 🔍
-1% - +4%
-0.13ms - +0.99ms		-

run-warmup-4

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main39.16ms - 40.85ms-unsure 🔍
-1% - +5%
-0.31ms - +2.05ms		unsure 🔍
-4% - +1%
-1.56ms - +0.47ms
preact-local38.31ms - 39.96msunsure 🔍
-5% - +1%
-2.05ms - +0.31ms		-faster ✔
1% - 6%
0.41ms - 2.41ms
preact-hooks39.98ms - 41.12msunsure 🔍
-1% - +4%
-0.47ms - +1.56ms		slower ❌
1% - 6%
0.41ms - 2.41ms		-

run-final

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main22.77ms - 23.35ms-unsure 🔍
-2% - +2%
-0.37ms - +0.47ms		unsure 🔍
-2% - +1%
-0.49ms - +0.29ms
preact-local22.70ms - 23.32msunsure 🔍
-2% - +2%
-0.47ms - +0.37ms		-unsure 🔍
-2% - +1%
-0.55ms - +0.25ms
preact-hooks22.90ms - 23.42msunsure 🔍
-1% - +2%
-0.29ms - +0.49ms		unsure 🔍
-1% - +2%
-0.25ms - +0.55ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main32.31ms - 33.96ms-unsure 🔍
-5% - +2%
-1.70ms - +0.66ms		unsure 🔍
-4% - +3%
-1.43ms - +0.89ms
preact-local32.81ms - 34.50msunsure 🔍
-2% - +5%
-0.66ms - +1.70ms		-unsure 🔍
-3% - +4%
-0.92ms - +1.42ms
preact-hooks32.59ms - 34.22msunsure 🔍
-3% - +4%
-0.89ms - +1.43ms		unsure 🔍
-4% - +3%
-1.42ms - +0.92ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.28ms - 3.29ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
0% - 1%
0.01ms - 0.03ms
preact-local3.28ms - 3.29msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.30ms - 3.31msslower ❌
0% - 1%
0.01ms - 0.03ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main920.71ms - 928.32ms-unsure 🔍
-1% - +0%
-7.38ms - +3.67ms		unsure 🔍
-1% - +0%
-8.08ms - +1.22ms
preact-local922.36ms - 930.38msunsure 🔍
-0% - +1%
-3.67ms - +7.38ms		-unsure 🔍
-1% - +0%
-6.39ms - +3.25ms
preact-hooks925.27ms - 930.61msunsure 🔍
-0% - +1%
-1.22ms - +8.08ms		unsure 🔍
-0% - +1%
-3.25ms - +6.39ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.32ms - 26.32ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local26.32ms - 26.32msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks26.34ms - 26.34msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.58ms - 16.63ms-unsure 🔍
-0% - +0%
-0.06ms - +0.03ms		unsure 🔍
-1% - +0%
-0.09ms - +0.02ms
preact-local16.59ms - 16.66msunsure 🔍
-0% - +0%
-0.03ms - +0.06ms		-unsure 🔍
-0% - +0%
-0.08ms - +0.05ms
preact-hooks16.59ms - 16.69msunsure 🔍
-0% - +1%
-0.02ms - +0.09ms		unsure 🔍
-0% - +0%
-0.05ms - +0.08ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1.33ms - 1.33ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.02ms - 0.03ms
preact-local1.33ms - 1.33msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.02ms - 0.03ms
preact-hooks1.35ms - 1.36msslower ❌
2% - 2%
0.02ms - 0.03ms		slower ❌
2% - 2%
0.02ms - 0.03ms		-
hydrate1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main81.48ms - 83.84ms-unsure 🔍
-1% - +2%
-0.99ms - +1.89ms		unsure 🔍
-0% - +3%
-0.37ms - +2.10ms
preact-local81.39ms - 83.04msunsure 🔍
-2% - +1%
-1.89ms - +0.99ms		-unsure 🔍
-1% - +2%
-0.49ms - +1.32ms
preact-hooks81.42ms - 82.18msunsure 🔍
-3% - +0%
-2.10ms - +0.37ms		unsure 🔍
-2% - +1%
-1.32ms - +0.49ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main6.10ms - 6.10ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local6.10ms - 6.10msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks6.12ms - 6.12msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
many_updates

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.44ms - 16.71ms-unsure 🔍
-2% - +1%
-0.37ms - +0.09ms		unsure 🔍
-2% - +1%
-0.28ms - +0.13ms
preact-local16.53ms - 16.91msunsure 🔍
-1% - +2%
-0.09ms - +0.37ms		-unsure 🔍
-1% - +2%
-0.18ms - +0.32ms
preact-hooks16.49ms - 16.81msunsure 🔍
-1% - +2%
-0.13ms - +0.28ms		unsure 🔍
-2% - +1%
-0.32ms - +0.18ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main4.44ms - 4.44ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
0% - 1%
0.02ms - 0.03ms
preact-local4.44ms - 4.44msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
0% - 1%
0.02ms - 0.03ms
preact-hooks4.46ms - 4.47msslower ❌
0% - 1%
0.02ms - 0.03ms		slower ❌
0% - 1%
0.02ms - 0.03ms		-
text_update

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main2.55ms - 2.64ms-unsure 🔍
-3% - +1%
-0.08ms - +0.03ms		faster ✔
4% - 9%
0.12ms - 0.24ms
preact-local2.58ms - 2.66msunsure 🔍
-1% - +3%
-0.03ms - +0.08ms		-faster ✔
4% - 8%
0.10ms - 0.21ms
preact-hooks2.73ms - 2.82msslower ❌
5% - 9%
0.12ms - 0.24ms		slower ❌
4% - 8%
0.10ms - 0.21ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.57ms - 0.58ms-unsure 🔍
-1% - +2%
-0.00ms - +0.01ms		faster ✔
0% - 2%
0.00ms - 0.01ms
preact-local0.57ms - 0.58msunsure 🔍
-2% - +1%
-0.01ms - +0.00ms		-faster ✔
1% - 3%
0.01ms - 0.02ms
preact-hooks0.59ms - 0.59msslower ❌
0% - 2%
0.00ms - 0.01ms		slower ❌
1% - 3%
0.01ms - 0.02ms		-
todo

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main27.35ms - 27.72ms-unsure 🔍
-1% - +1%
-0.24ms - +0.26ms		faster ✔
1% - 3%
0.36ms - 0.92ms
preact-local27.35ms - 27.69msunsure 🔍
-1% - +1%
-0.26ms - +0.24ms		-faster ✔
1% - 3%
0.39ms - 0.92ms
preact-hooks27.97ms - 28.39msslower ❌
1% - 3%
0.36ms - 0.92ms		slower ❌
1% - 3%
0.39ms - 0.92ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.79ms - 0.79ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
3% - 3%
0.02ms - 0.02ms
preact-local0.79ms - 0.79msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
3% - 3%
0.02ms - 0.02ms
preact-hooks0.82ms - 0.82msslower ❌
3% - 3%
0.02ms - 0.02ms		slower ❌
3% - 3%
0.02ms - 0.02ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Dec 29, 2023 •
edited
Loading

Coverage Status

coverage: 99.467%. remained the same
when pulling c6f82fd on ontouchcap
into 899e9d9 on main.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 29, 2023 •
edited
Loading

Size Change: +17 B (0%)

Total Size: 59.7 kB

Filename Size Change
dist/preact.js 4.51 kB +3 B (0%)
dist/preact.min.js 4.54 kB +3 B (0%)
dist/preact.min.module.js 4.54 kB +3 B (0%)
dist/preact.min.umd.js 4.57 kB +3 B (0%)
dist/preact.module.js 4.53 kB +2 B (0%)
dist/preact.umd.js 4.59 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.98 kB 0 B
compat/dist/compat.module.js 3.9 kB 0 B
compat/dist/compat.umd.js 4.04 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
hooks/dist/hooks.js 1.52 kB 0 B
hooks/dist/hooks.module.js 1.56 kB 0 B
hooks/dist/hooks.umd.js 1.6 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

marvinhagemeister
marvinhagemeister approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@JoviDeCroock JoviDeCroock merged commit 13b0afb into main Jan 2, 2024
13 checks passed
@JoviDeCroock JoviDeCroock deleted the ontouchcap branch January 2, 2024 09:53
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 3, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request May 21, 2024
Open
@q1blue q1blue mentioned this pull request May 24, 2024
Open
@Leeze555 Leeze555 mentioned this pull request May 31, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jun 5, 2024
Open
@Jircs1 Jircs1 mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
Open
@vAHiD55555 vAHiD55555 mentioned this pull request Jun 20, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jul 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[preact/compat] onTouchMoveCapture not processed
3 participants
@JoviDeCroock @coveralls @marvinhagemeister