Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(props): event-listenerssafari 12.3 fix #4253

Merged
merged 1 commit into from Jan 16, 2024
Merged

fix(props): event-listenerssafari 12.3 fix #4253

merged 1 commit into from Jan 16, 2024

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jan 11, 2024 •
edited

Fixes #4258

somehow in Safari 12.3 sometimes this._listeners isn't set but events work 😅

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 11, 2024 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -0% - +1% (-0.30ms - +1.03ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -6% - +1% (-1.85ms - +0.42ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -1% - +1% (-5.40ms - +7.93ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +1% (-0.07ms - +0.16ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +5% (-0.22ms - +3.77ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -1% - +2% (-0.20ms - +0.40ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -3% - +1% (-0.07ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.25ms - +0.40ms)
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text_update: slower ❌ 0% - 2% (0.00ms - 0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main

Results

02_replace1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main84.58ms - 85.55ms-unsure 🔍
-1% - +0%
-1.03ms - +0.30ms		unsure 🔍
-1% - +1%
-0.98ms - +0.48ms
preact-local84.98ms - 85.88msunsure 🔍
-0% - +1%
-0.30ms - +1.03ms		-unsure 🔍
-1% - +1%
-0.59ms - +0.83ms
preact-hooks84.77ms - 85.86msunsure 🔍
-1% - +1%
-0.48ms - +0.98ms		unsure 🔍
-1% - +1%
-0.83ms - +0.59ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.32ms - 3.32ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.32ms - 3.32msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.03ms
preact-hooks3.34ms - 3.34msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
1% - 1%
0.02ms - 0.03ms		-

run-warmup-0

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main31.07ms - 32.26ms-unsure 🔍
-3% - +2%
-0.96ms - +0.76ms		faster ✔
1% - 5%
0.19ms - 1.79ms
preact-local31.15ms - 32.38msunsure 🔍
-2% - +3%
-0.76ms - +0.96ms		-faster ✔
0% - 5%
0.07ms - 1.70ms
preact-hooks32.12ms - 33.18msslower ❌
1% - 6%
0.19ms - 1.79ms		slower ❌
0% - 5%
0.07ms - 1.70ms		-

run-warmup-1

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main39.86ms - 41.36ms-unsure 🔍
-1% - +4%
-0.51ms - +1.78ms		unsure 🔍
-4% - +1%
-1.48ms - +0.39ms
preact-local39.11ms - 40.83msunsure 🔍
-4% - +1%
-1.78ms - +0.51ms		-faster ✔
0% - 5%
0.16ms - 2.21ms
preact-hooks40.59ms - 41.71msunsure 🔍
-1% - +4%
-0.39ms - +1.48ms		slower ❌
0% - 6%
0.16ms - 2.21ms		-

run-warmup-2

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main30.14ms - 30.98ms-unsure 🔍
-1% - +2%
-0.39ms - +0.60ms		unsure 🔍
-3% - +1%
-1.09ms - +0.20ms
preact-local30.19ms - 30.71msunsure 🔍
-2% - +1%
-0.60ms - +0.39ms		-unsure 🔍
-4% - -0%
-1.10ms - +0.00ms
preact-hooks30.52ms - 31.49msunsure 🔍
-1% - +4%
-0.20ms - +1.09ms		unsure 🔍
-0% - +4%
-0.00ms - +1.10ms		-

run-warmup-3

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main23.64ms - 24.63ms-unsure 🔍
-1% - +3%
-0.29ms - +0.73ms		unsure 🔍
-3% - +2%
-0.70ms - +0.44ms
preact-local23.80ms - 24.02msunsure 🔍
-3% - +1%
-0.73ms - +0.29ms		-faster ✔
0% - 3%
0.04ms - 0.66ms
preact-hooks23.98ms - 24.55msunsure 🔍
-2% - +3%
-0.44ms - +0.70ms		slower ❌
0% - 3%
0.04ms - 0.66ms		-

run-warmup-4

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main39.52ms - 41.06ms-unsure 🔍
-2% - +3%
-0.89ms - +1.16ms		unsure 🔍
-5% - +0%
-1.88ms - +0.02ms
preact-local39.48ms - 40.83msunsure 🔍
-3% - +2%
-1.16ms - +0.89ms		-faster ✔
0% - 5%
0.19ms - 1.94ms
preact-hooks40.66ms - 41.78msunsure 🔍
-0% - +5%
-0.02ms - +1.88ms		slower ❌
0% - 5%
0.19ms - 1.94ms		-

run-final

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main22.45ms - 22.93ms-unsure 🔍
-2% - +1%
-0.54ms - +0.14ms		faster ✔
0% - 3%
0.03ms - 0.74ms
preact-local22.65ms - 23.14msunsure 🔍
-1% - +2%
-0.14ms - +0.54ms		-unsure 🔍
-2% - +1%
-0.54ms - +0.18ms
preact-hooks22.81ms - 23.34msslower ❌
0% - 3%
0.03ms - 0.74ms		unsure 🔍
-1% - +2%
-0.18ms - +0.54ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main30.41ms - 32.01ms-unsure 🔍
-1% - +6%
-0.42ms - +1.85ms		unsure 🔍
-1% - +6%
-0.38ms - +1.75ms
preact-local29.69ms - 31.31msunsure 🔍
-6% - +1%
-1.85ms - +0.42ms		-unsure 🔍
-4% - +3%
-1.10ms - +1.04ms
preact-hooks29.83ms - 31.23msunsure 🔍
-6% - +1%
-1.75ms - +0.38ms		unsure 🔍
-3% - +4%
-1.04ms - +1.10ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.28ms - 3.29ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms		faster ✔
0% - 1%
0.01ms - 0.02ms
preact-local3.28ms - 3.29msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.30ms - 3.31msslower ❌
0% - 1%
0.01ms - 0.02ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main919.70ms - 929.16ms-unsure 🔍
-1% - +1%
-7.93ms - +5.40ms		unsure 🔍
-1% - +0%
-13.49ms - +1.58ms
preact-local921.00ms - 930.39msunsure 🔍
-1% - +1%
-5.40ms - +7.93ms		-unsure 🔍
-1% - +0%
-12.20ms - +2.82ms
preact-hooks924.52ms - 936.25msunsure 🔍
-0% - +1%
-1.58ms - +13.49ms		unsure 🔍
-0% - +1%
-2.82ms - +12.20ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.32ms - 26.32ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local26.32ms - 26.32msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks26.34ms - 26.34msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.58ms - 16.66ms-unsure 🔍
-1% - +0%
-0.16ms - +0.07ms		unsure 🔍
-1% - +0%
-0.25ms - +0.03ms
preact-local16.55ms - 16.78msunsure 🔍
-0% - +1%
-0.07ms - +0.16ms		-unsure 🔍
-1% - +1%
-0.24ms - +0.11ms
preact-hooks16.60ms - 16.86msunsure 🔍
-0% - +1%
-0.03ms - +0.25ms		unsure 🔍
-1% - +1%
-0.11ms - +0.24ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1.33ms - 1.33ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.02ms - 0.03ms
preact-local1.33ms - 1.33msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.03ms - 0.03ms
preact-hooks1.36ms - 1.36msslower ❌
2% - 2%
0.02ms - 0.03ms		slower ❌
2% - 2%
0.03ms - 0.03ms		-
hydrate1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main82.10ms - 83.20ms-unsure 🔍
-4% - +0%
-3.77ms - +0.22ms		unsure 🔍
-3% - +1%
-2.44ms - +0.76ms
preact-local82.51ms - 86.35msunsure 🔍
-0% - +5%
-0.22ms - +3.77ms		-unsure 🔍
-2% - +4%
-1.50ms - +3.37ms
preact-hooks81.99ms - 84.99msunsure 🔍
-1% - +3%
-0.76ms - +2.44ms		unsure 🔍
-4% - +2%
-3.37ms - +1.50ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main6.10ms - 6.10ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local6.10ms - 6.10msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks6.12ms - 6.12msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
many_updates

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main18.01ms - 18.42ms-unsure 🔍
-2% - +1%
-0.40ms - +0.20ms		unsure 🔍
-2% - +1%
-0.44ms - +0.19ms
preact-local18.09ms - 18.54msunsure 🔍
-1% - +2%
-0.20ms - +0.40ms		-unsure 🔍
-2% - +2%
-0.35ms - +0.30ms
preact-hooks18.10ms - 18.58msunsure 🔍
-1% - +2%
-0.19ms - +0.44ms		unsure 🔍
-2% - +2%
-0.30ms - +0.35ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main4.44ms - 4.44ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.01ms
preact-local4.44ms - 4.44msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks4.46ms - 4.46msunsure 🔍
+0% - +0%
+0.01ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main2.57ms - 2.64ms-unsure 🔍
-1% - +3%
-0.03ms - +0.07ms		faster ✔
5% - 8%
0.13ms - 0.23ms
preact-local2.55ms - 2.62msunsure 🔍
-3% - +1%
-0.07ms - +0.03ms		-faster ✔
5% - 9%
0.15ms - 0.25ms
preact-hooks2.75ms - 2.82msslower ❌
5% - 9%
0.13ms - 0.23ms		slower ❌
6% - 10%
0.15ms - 0.25ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.56ms - 0.57ms-faster ✔
0% - 2%
0.00ms - 0.01ms		faster ✔
3% - 4%
0.02ms - 0.03ms
preact-local0.57ms - 0.58msslower ❌
0% - 2%
0.00ms - 0.01ms		-faster ✔
2% - 4%
0.01ms - 0.02ms
preact-hooks0.59ms - 0.59msslower ❌
3% - 4%
0.02ms - 0.03ms		slower ❌
2% - 4%
0.01ms - 0.02ms		-
todo

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.48ms - 27.02ms-unsure 🔍
-1% - +1%
-0.40ms - +0.25ms		faster ✔
1% - 4%
0.29ms - 0.97ms
preact-local26.65ms - 27.00msunsure 🔍
-1% - +1%
-0.25ms - +0.40ms		-faster ✔
1% - 3%
0.29ms - 0.83ms
preact-hooks27.18ms - 27.58msslower ❌
1% - 4%
0.29ms - 0.97ms		slower ❌
1% - 3%
0.29ms - 0.83ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.79ms - 0.79ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
3% - 3%
0.03ms - 0.03ms
preact-local0.79ms - 0.79msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
3% - 3%
0.03ms - 0.03ms
preact-hooks0.82ms - 0.82msslower ❌
3% - 3%
0.03ms - 0.03ms		slower ❌
3% - 3%
0.03ms - 0.03ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Jan 11, 2024 •
edited

Coverage Status

coverage: 99.473% (+0.001%) from 99.472%
when pulling ed1304f on safari-123-fix
into f7ccb90 on main.

@github-actions GitHub Actions
Copy link

Size Change: +49 B (0%)

Total Size: 60 kB

Filename Size Change
dist/preact.js 4.54 kB +8 B (0%)
dist/preact.min.js 4.58 kB +9 B (0%)
dist/preact.min.module.js 4.58 kB +9 B (0%)
dist/preact.min.umd.js 4.61 kB +8 B (0%)
dist/preact.module.js 4.57 kB +7 B (0%)
dist/preact.umd.js 4.62 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.98 kB 0 B
compat/dist/compat.module.js 3.9 kB 0 B
compat/dist/compat.umd.js 4.04 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock changed the title fix(props): event-listenres safari 12.3 fix fix(props): event-listenerssafari 12.3 fix Jan 16, 2024
@JoviDeCroock JoviDeCroock merged commit b3480e8 into main Jan 16, 2024
15 checks passed
@JoviDeCroock JoviDeCroock deleted the safari-123-fix branch January 16, 2024 11:17
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: undefined is not an object (evaluating 'this.l[e.type+!1]')
3 participants
@JoviDeCroock @coveralls @marvinhagemeister