Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #4234 from preactjs/multi-root-shared-commit" #4297

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Revert "Merge pull request #4234 from preactjs/multi-root-shared-commit" #4297

merged 2 commits into from
Mar 17, 2024

Conversation

JoviDeCroock
Copy link
Member

This reverts commit f7ccb90, reversing changes made to e1f0d3e.

Fixes #4296
Fixes #4286

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • 02_replace1k: slower ❌ 0% - 3% (0.05ms - 2.42ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -2% - +4% (-0.81ms - +1.23ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -1% - +1% (-5.45ms - +9.45ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +0% (-0.04ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +2% (-1.08ms - +1.81ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -0% - +3% (-0.07ms - +0.54ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -2% - +3% (-0.05ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +0% (-0.15ms - +0.12ms)
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
02_replace1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main75.50ms - 76.71ms-faster ✔
0% - 3%
0.05ms - 2.42ms		faster ✔
1% - 4%
0.78ms - 3.20ms
preact-local76.32ms - 78.37msslower ❌
0% - 3%
0.05ms - 2.42ms		-unsure 🔍
-3% - +1%
-2.22ms - +0.71ms
preact-hooks77.05ms - 79.15msslower ❌
1% - 4%
0.78ms - 3.20ms		unsure 🔍
-1% - +3%
-0.71ms - +2.22ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.40ms - 3.40ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.40ms - 3.40msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.03ms
preact-hooks3.43ms - 3.43msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
1% - 1%
0.02ms - 0.03ms		-

run-warmup-0

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main29.58ms - 30.20ms-unsure 🔍
-3% - +2%
-0.96ms - +0.59ms		unsure 🔍
-3% - +0%
-1.00ms - +0.14ms
preact-local29.36ms - 30.79msunsure 🔍
-2% - +3%
-0.59ms - +0.96ms		-unsure 🔍
-4% - +2%
-1.11ms - +0.61ms
preact-hooks29.85ms - 30.80msunsure 🔍
-0% - +3%
-0.14ms - +1.00ms		unsure 🔍
-2% - +4%
-0.61ms - +1.11ms		-

run-warmup-1

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main40.19ms - 41.66ms-unsure 🔍
-4% - +1%
-1.71ms - +0.22ms		unsure 🔍
-3% - +1%
-1.40ms - +0.41ms
preact-local41.04ms - 42.30msunsure 🔍
-1% - +4%
-0.22ms - +1.71ms		-unsure 🔍
-1% - +3%
-0.57ms - +1.08ms
preact-hooks40.88ms - 41.95msunsure 🔍
-1% - +3%
-0.41ms - +1.40ms		unsure 🔍
-3% - +1%
-1.08ms - +0.57ms		-

run-warmup-2

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main27.14ms - 27.96ms-unsure 🔍
-2% - +2%
-0.53ms - +0.54ms		unsure 🔍
-1% - +2%
-0.31ms - +0.57ms
preact-local27.20ms - 27.90msunsure 🔍
-2% - +2%
-0.54ms - +0.53ms		-unsure 🔍
-1% - +2%
-0.26ms - +0.51ms
preact-hooks27.25ms - 27.60msunsure 🔍
-2% - +1%
-0.57ms - +0.31ms		unsure 🔍
-2% - +1%
-0.51ms - +0.26ms		-

run-warmup-3

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main25.47ms - 26.51ms-unsure 🔍
-4% - +2%
-1.19ms - +0.44ms		unsure 🔍
-3% - +3%
-0.74ms - +0.72ms
preact-local25.74ms - 26.99msunsure 🔍
-2% - +5%
-0.44ms - +1.19ms		-unsure 🔍
-2% - +5%
-0.45ms - +1.17ms
preact-hooks25.49ms - 26.51msunsure 🔍
-3% - +3%
-0.72ms - +0.74ms		unsure 🔍
-4% - +2%
-1.17ms - +0.45ms		-

run-warmup-4

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main29.13ms - 30.80ms-unsure 🔍
-5% - +3%
-1.53ms - +1.05ms		unsure 🔍
-5% - +1%
-1.67ms - +0.21ms
preact-local29.22ms - 31.19msunsure 🔍
-4% - +5%
-1.05ms - +1.53ms		-unsure 🔍
-5% - +2%
-1.57ms - +0.59ms
preact-hooks30.25ms - 31.14msunsure 🔍
-1% - +6%
-0.21ms - +1.67ms		unsure 🔍
-2% - +5%
-0.59ms - +1.57ms		-

run-final

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main23.17ms - 23.84ms-unsure 🔍
-5% - +0%
-1.17ms - +0.11ms		faster ✔
3% - 8%
0.79ms - 2.14ms
preact-local23.49ms - 24.57msunsure 🔍
-0% - +5%
-0.11ms - +1.17ms		-faster ✔
1% - 7%
0.14ms - 1.74ms
preact-hooks24.38ms - 25.55msslower ❌
3% - 9%
0.79ms - 2.14ms		slower ❌
1% - 7%
0.14ms - 1.74ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main33.20ms - 34.71ms-unsure 🔍
-4% - +2%
-1.23ms - +0.81ms		unsure 🔍
-4% - +2%
-1.48ms - +0.74ms
preact-local33.48ms - 34.85msunsure 🔍
-2% - +4%
-0.81ms - +1.23ms		-unsure 🔍
-4% - +3%
-1.22ms - +0.90ms
preact-hooks33.52ms - 35.14msunsure 🔍
-2% - +4%
-0.74ms - +1.48ms		unsure 🔍
-3% - +4%
-0.90ms - +1.22ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.37ms - 3.38ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.37ms - 3.38msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.02ms - 0.03ms
preact-hooks3.39ms - 3.40msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
0% - 1%
0.02ms - 0.03ms		-
07_create10k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main888.27ms - 894.62ms-unsure 🔍
-1% - +1%
-9.45ms - +5.45ms		unsure 🔍
-1% - +0%
-13.46ms - +1.67ms
preact-local886.70ms - 900.19msunsure 🔍
-1% - +1%
-5.45ms - +9.45ms		-unsure 🔍
-2% - +1%
-13.52ms - +5.72ms
preact-hooks890.48ms - 904.21msunsure 🔍
-0% - +2%
-1.67ms - +13.46ms		unsure 🔍
-1% - +2%
-5.72ms - +13.52ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.40ms - 26.40ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local26.40ms - 26.40msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks26.42ms - 26.42msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.57ms - 16.61ms-unsure 🔍
-0% - +0%
-0.02ms - +0.04ms		unsure 🔍
-0% - +0%
-0.04ms - +0.04ms
preact-local16.56ms - 16.60msunsure 🔍
-0% - +0%
-0.04ms - +0.02ms		-unsure 🔍
-0% - +0%
-0.05ms - +0.02ms
preact-hooks16.56ms - 16.62msunsure 🔍
-0% - +0%
-0.04ms - +0.04ms		unsure 🔍
-0% - +0%
-0.02ms - +0.05ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1.42ms - 1.43ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.02ms - 0.03ms
preact-local1.42ms - 1.43msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.02ms - 0.03ms
preact-hooks1.45ms - 1.45msslower ❌
2% - 2%
0.02ms - 0.03ms		slower ❌
2% - 2%
0.02ms - 0.03ms		-
hydrate1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main75.71ms - 77.16ms-unsure 🔍
-2% - +1%
-1.81ms - +1.08ms		unsure 🔍
-2% - +1%
-1.80ms - +0.83ms
preact-local75.56ms - 78.05msunsure 🔍
-1% - +2%
-1.08ms - +1.81ms		-unsure 🔍
-2% - +2%
-1.78ms - +1.54ms
preact-hooks75.83ms - 78.01msunsure 🔍
-1% - +2%
-0.83ms - +1.80ms		unsure 🔍
-2% - +2%
-1.54ms - +1.78ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main6.10ms - 6.11ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms		unsure 🔍
-0% - -0%
-0.03ms - -0.01ms
preact-local6.10ms - 6.11msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.01ms
preact-hooks6.12ms - 6.12msunsure 🔍
+0% - +0%
+0.01ms - +0.03ms		unsure 🔍
+0% - +0%
+0.01ms - +0.02ms		-
many_updates

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.51ms - 16.59ms-unsure 🔍
-3% - +0%
-0.54ms - +0.07ms		unsure 🔍
-1% - +0%
-0.13ms - +0.02ms
preact-local16.48ms - 17.09msunsure 🔍
-0% - +3%
-0.07ms - +0.54ms		-unsure 🔍
-1% - +3%
-0.13ms - +0.49ms
preact-hooks16.54ms - 16.68msunsure 🔍
-0% - +1%
-0.02ms - +0.13ms		unsure 🔍
-3% - +1%
-0.49ms - +0.13ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main4.52ms - 4.52ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local4.52ms - 4.52msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks4.54ms - 4.54msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main2.43ms - 2.52ms-unsure 🔍
-3% - +2%
-0.08ms - +0.05ms		faster ✔
5% - 9%
0.12ms - 0.23ms
preact-local2.44ms - 2.54msunsure 🔍
-2% - +3%
-0.05ms - +0.08ms		-faster ✔
4% - 8%
0.10ms - 0.22ms
preact-hooks2.62ms - 2.69msslower ❌
5% - 10%
0.12ms - 0.23ms		slower ❌
4% - 9%
0.10ms - 0.22ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.80ms - 0.80ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
3% - 6%
0.02ms - 0.05ms
preact-local0.80ms - 0.80msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
3% - 6%
0.02ms - 0.05ms
preact-hooks0.83ms - 0.85msslower ❌
3% - 6%
0.02ms - 0.05ms		slower ❌
3% - 6%
0.02ms - 0.05ms		-
todo

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.48ms - 26.67ms-unsure 🔍
-0% - +1%
-0.12ms - +0.15ms		faster ✔
3% - 5%
0.74ms - 1.34ms
preact-local26.46ms - 26.66msunsure 🔍
-1% - +0%
-0.15ms - +0.12ms		-faster ✔
3% - 5%
0.76ms - 1.36ms
preact-hooks27.33ms - 27.90msslower ❌
3% - 5%
0.74ms - 1.34ms		slower ❌
3% - 5%
0.76ms - 1.36ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.88ms - 0.88ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms		faster ✔
3% - 3%
0.03ms - 0.03ms
preact-local0.88ms - 0.88msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-faster ✔
3% - 3%
0.03ms - 0.03ms
preact-hooks0.90ms - 0.91msslower ❌
3% - 3%
0.03ms - 0.03ms		slower ❌
3% - 3%
0.03ms - 0.03ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024 •
edited
Loading

Size Change: -176 B (0%)

Total Size: 60 kB

Filename Size Change
dist/preact.js 4.53 kB -29 B (0%)
dist/preact.min.js 4.57 kB -28 B (0%)
dist/preact.min.module.js 4.56 kB -30 B (0%)
dist/preact.min.umd.js 4.6 kB -29 B (0%)
dist/preact.module.js 4.55 kB -33 B (0%)
dist/preact.umd.js 4.61 kB -27 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4 kB 0 B
compat/dist/compat.module.js 3.92 kB 0 B
compat/dist/compat.umd.js 4.06 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 316 B 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Mar 2, 2024 •
edited
Loading

Coverage Status

coverage: 99.467% (-0.005%) from 99.472%
when pulling e8f98de on undo-batching
into c5f0483 on main.

abdotaouala
abdotaouala suggested changes Mar 7, 2024
View reviewed changes
src/diff/index.js
@@ -311,6 +311,8 @@ export function diff(
* @param {VNode} root
*/
export function commitRoot(commitQueue, root, refQueue) {
root._nextDom = undefined;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you put undefined in _nextDom ?

@JoviDeCroock JoviDeCroock merged commit dc55841 into main Mar 17, 2024
5 of 13 checks passed
@JoviDeCroock JoviDeCroock deleted the undo-batching branch March 17, 2024 14:45
@JoviDeCroock JoviDeCroock mentioned this pull request Mar 18, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request May 21, 2024
Open
@q1blue q1blue mentioned this pull request May 24, 2024
Open
@Leeze555 Leeze555 mentioned this pull request May 31, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jun 5, 2024
Open
@Jircs1 Jircs1 mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
Open
@vAHiD55555 vAHiD55555 mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdotaouala abdotaouala abdotaouala requested changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@JoviDeCroock @coveralls @marvinhagemeister @abdotaouala