Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add special case for focusIn and focusOut #4316

Merged
merged 1 commit into from Mar 21, 2024
Merged

Add special case for focusIn and focusOut #4316

merged 1 commit into from Mar 21, 2024

Conversation

JoviDeCroock
Copy link
Member

Fixes #4314

The DOM-node in Chrome does not specify FocusIn as a valid event

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +1% (-0.88ms - +0.79ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -1% - +6% (-0.22ms - +1.86ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -1% - +1% (-5.84ms - +10.14ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +0% (-0.06ms - +0.08ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-1.72ms - +0.99ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -4% - +4% (-0.63ms - +0.67ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -16% - +5% (-0.43ms - +0.15ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +3% (-0.39ms - +0.71ms)
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main

Results

02_replace1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main69.03ms - 70.48ms-unsure 🔍
-1% - +1%
-0.79ms - +0.88ms		unsure 🔍
-2% - +1%
-1.17ms - +0.54ms
preact-local69.30ms - 70.13msunsure 🔍
-1% - +1%
-0.88ms - +0.79ms		-unsure 🔍
-1% - +0%
-0.98ms - +0.26ms
preact-hooks69.62ms - 70.53msunsure 🔍
-1% - +2%
-0.54ms - +1.17ms		unsure 🔍
-0% - +1%
-0.26ms - +0.98ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.40ms - 3.40ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.40ms - 3.40msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.03ms
preact-hooks3.43ms - 3.43msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
1% - 1%
0.02ms - 0.03ms		-

run-warmup-0

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main27.67ms - 28.27ms-unsure 🔍
-2% - +1%
-0.47ms - +0.40ms		faster ✔
1% - 4%
0.27ms - 1.25ms
preact-local27.69ms - 28.32msunsure 🔍
-1% - +2%
-0.40ms - +0.47ms		-faster ✔
1% - 4%
0.23ms - 1.23ms
preact-hooks28.34ms - 29.12msslower ❌
1% - 4%
0.27ms - 1.25ms		slower ❌
1% - 4%
0.23ms - 1.23ms		-

run-warmup-1

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main36.06ms - 37.57ms-unsure 🔍
-3% - +3%
-1.06ms - +1.01ms		faster ✔
0% - 5%
0.11ms - 1.81ms
preact-local36.14ms - 37.54msunsure 🔍
-3% - +3%
-1.01ms - +1.06ms		-faster ✔
0% - 5%
0.14ms - 1.74ms
preact-hooks37.40ms - 38.16msslower ❌
0% - 5%
0.11ms - 1.81ms		slower ❌
0% - 5%
0.14ms - 1.74ms		-

run-warmup-2

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main24.18ms - 24.43ms-unsure 🔍
-1% - +0%
-0.34ms - +0.08ms		unsure 🔍
-1% - +0%
-0.33ms - +0.05ms
preact-local24.27ms - 24.60msunsure 🔍
-0% - +1%
-0.08ms - +0.34ms		-unsure 🔍
-1% - +1%
-0.22ms - +0.21ms
preact-hooks24.30ms - 24.58msunsure 🔍
-0% - +1%
-0.05ms - +0.33ms		unsure 🔍
-1% - +1%
-0.21ms - +0.22ms		-

run-warmup-3

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main23.01ms - 23.96ms-unsure 🔍
-3% - +3%
-0.59ms - +0.74ms		unsure 🔍
-6% - +1%
-1.38ms - +0.22ms
preact-local22.94ms - 23.87msunsure 🔍
-3% - +2%
-0.74ms - +0.59ms		-unsure 🔍
-6% - +1%
-1.45ms - +0.14ms
preact-hooks23.42ms - 24.71msunsure 🔍
-1% - +6%
-0.22ms - +1.38ms		unsure 🔍
-1% - +6%
-0.14ms - +1.45ms		-

run-warmup-4

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main25.63ms - 27.14ms-unsure 🔍
-3% - +4%
-0.87ms - +1.14ms		unsure 🔍
-4% - +2%
-1.00ms - +0.64ms
preact-local25.58ms - 26.92msunsure 🔍
-4% - +3%
-1.14ms - +0.87ms		-unsure 🔍
-4% - +2%
-1.06ms - +0.43ms
preact-hooks26.24ms - 26.89msunsure 🔍
-2% - +4%
-0.64ms - +1.00ms		unsure 🔍
-2% - +4%
-0.43ms - +1.06ms		-

run-final

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main21.71ms - 22.47ms-unsure 🔍
-2% - +3%
-0.42ms - +0.57ms		unsure 🔍
-3% - +1%
-0.68ms - +0.32ms
preact-local21.69ms - 22.33msunsure 🔍
-3% - +2%
-0.57ms - +0.42ms		-unsure 🔍
-3% - +1%
-0.71ms - +0.19ms
preact-hooks21.95ms - 22.59msunsure 🔍
-1% - +3%
-0.32ms - +0.68ms		unsure 🔍
-1% - +3%
-0.19ms - +0.71ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main32.27ms - 33.75ms-unsure 🔍
-5% - +1%
-1.86ms - +0.22ms		unsure 🔍
-6% - +1%
-1.96ms - +0.23ms
preact-local33.10ms - 34.57msunsure 🔍
-1% - +6%
-0.22ms - +1.86ms		-unsure 🔍
-3% - +3%
-1.14ms - +1.05ms
preact-hooks33.06ms - 34.69msunsure 🔍
-1% - +6%
-0.23ms - +1.96ms		unsure 🔍
-3% - +3%
-1.05ms - +1.14ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.37ms - 3.38ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.37ms - 3.38msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.39ms - 3.40msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main901.28ms - 909.89ms-unsure 🔍
-1% - +1%
-10.14ms - +5.84ms		unsure 🔍
-1% - +0%
-9.45ms - +1.81ms
preact-local901.01ms - 914.47msunsure 🔍
-1% - +1%
-5.84ms - +10.14ms		-unsure 🔍
-1% - +1%
-9.31ms - +5.97ms
preact-hooks905.79ms - 913.03msunsure 🔍
-0% - +1%
-1.81ms - +9.45ms		unsure 🔍
-1% - +1%
-5.97ms - +9.31ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.40ms - 26.40ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local26.40ms - 26.40msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks26.42ms - 26.42msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.60ms - 16.68ms-unsure 🔍
-0% - +0%
-0.08ms - +0.06ms		unsure 🔍
-1% - +0%
-0.11ms - +0.05ms
preact-local16.59ms - 16.70msunsure 🔍
-0% - +0%
-0.06ms - +0.08ms		-unsure 🔍
-1% - +0%
-0.11ms - +0.06ms
preact-hooks16.60ms - 16.74msunsure 🔍
-0% - +1%
-0.05ms - +0.11ms		unsure 🔍
-0% - +1%
-0.06ms - +0.11ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1.42ms - 1.42ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.02ms - 0.03ms
preact-local1.42ms - 1.42msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.03ms - 0.03ms
preact-hooks1.44ms - 1.44msslower ❌
2% - 2%
0.02ms - 0.03ms		slower ❌
2% - 2%
0.03ms - 0.03ms		-
hydrate1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main75.32ms - 77.29ms-unsure 🔍
-1% - +2%
-0.99ms - +1.72ms		unsure 🔍
-1% - +2%
-0.49ms - +1.87ms
preact-local75.01ms - 76.87msunsure 🔍
-2% - +1%
-1.72ms - +0.99ms		-unsure 🔍
-1% - +2%
-0.81ms - +1.46ms
preact-hooks74.97ms - 76.26msunsure 🔍
-2% - +1%
-1.87ms - +0.49ms		unsure 🔍
-2% - +1%
-1.46ms - +0.81ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main6.10ms - 6.10ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		unsure 🔍
-0% - -0%
-0.03ms - -0.02ms
preact-local6.10ms - 6.11msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.03ms
preact-hooks6.12ms - 6.13msunsure 🔍
+0% - +0%
+0.02ms - +0.03ms		slower ❌
0% - 1%
0.01ms - 0.03ms		-
many_updates

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main17.04ms - 17.98ms-unsure 🔍
-4% - +4%
-0.67ms - +0.63ms		unsure 🔍
-2% - +4%
-0.28ms - +0.76ms
preact-local17.08ms - 17.98msunsure 🔍
-4% - +4%
-0.63ms - +0.67ms		-unsure 🔍
-1% - +4%
-0.25ms - +0.76ms
preact-hooks17.04ms - 17.50msunsure 🔍
-4% - +2%
-0.76ms - +0.28ms		unsure 🔍
-4% - +1%
-0.76ms - +0.25ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main4.52ms - 4.53ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
0% - 1%
0.02ms - 0.02ms
preact-local4.52ms - 4.53msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
0% - 1%
0.02ms - 0.02ms
preact-hooks4.54ms - 4.55msslower ❌
0% - 1%
0.02ms - 0.02ms		slower ❌
0% - 1%
0.02ms - 0.02ms		-
text_update

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main2.35ms - 2.92ms-unsure 🔍
-6% - +17%
-0.15ms - +0.43ms		unsure 🔍
-14% - +7%
-0.38ms - +0.20ms
preact-local2.46ms - 2.53msunsure 🔍
-16% - +5%
-0.43ms - +0.15ms		-faster ✔
6% - 11%
0.17ms - 0.30ms
preact-hooks2.67ms - 2.78msunsure 🔍
-8% - +15%
-0.20ms - +0.38ms		slower ❌
7% - 12%
0.17ms - 0.30ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.80ms - 0.80ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
3% - 4%
0.02ms - 0.03ms
preact-local0.80ms - 0.80msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 4%
0.02ms - 0.03ms
preact-hooks0.82ms - 0.84msslower ❌
3% - 4%
0.02ms - 0.03ms		slower ❌
3% - 4%
0.02ms - 0.03ms		-
todo

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.76ms - 27.17ms-unsure 🔍
-3% - +1%
-0.71ms - +0.39ms		faster ✔
2% - 4%
0.60ms - 1.22ms
preact-local26.62ms - 27.64msunsure 🔍
-1% - +3%
-0.39ms - +0.71ms		-faster ✔
1% - 5%
0.19ms - 1.31ms
preact-hooks27.65ms - 28.10msslower ❌
2% - 5%
0.60ms - 1.22ms		slower ❌
1% - 5%
0.19ms - 1.31ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.88ms - 0.88ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms		faster ✔
3% - 3%
0.03ms - 0.03ms
preact-local0.88ms - 0.88msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-faster ✔
3% - 3%
0.03ms - 0.03ms
preact-hooks0.91ms - 0.91msslower ❌
3% - 3%
0.03ms - 0.03ms		slower ❌
3% - 3%
0.03ms - 0.03ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited

Size Change: +106 B (0%)

Total Size: 60.3 kB

Filename Size Change
dist/preact.js 4.56 kB +18 B (0%)
dist/preact.min.js 4.6 kB +17 B (0%)
dist/preact.min.module.js 4.59 kB +18 B (0%)
dist/preact.min.umd.js 4.63 kB +18 B (0%)
dist/preact.module.js 4.58 kB +17 B (0%)
dist/preact.umd.js 4.64 kB +18 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4.05 kB 0 B
compat/dist/compat.module.js 3.98 kB 0 B
compat/dist/compat.umd.js 4.11 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Mar 21, 2024 •
edited

Coverage Status

coverage: 99.601% (+0.1%) from 99.468%
when pulling e54fb3a on fix-focus-in-out
into b820d8b on main.

@JoviDeCroock JoviDeCroock merged commit a59a78c into main Mar 21, 2024
13 checks passed
@JoviDeCroock JoviDeCroock deleted the fix-focus-in-out branch March 21, 2024 11:52
@JoviDeCroock JoviDeCroock mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onFocusIn and onFocusOut events incorrectly set
3 participants
@JoviDeCroock @coveralls @marvinhagemeister