Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major(core): remove replaceNode functionality #4359

Open
wants to merge 2 commits into
base: breaking-changes-11
Choose a base branch
from

Conversation

JoviDeCroock
Copy link
Member

This removes the replaceNode functionality, you can still polyfill the functionality like this

Copy link

github-actions bot commented Apr 29, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-4.94ms - +3.10ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -3% - +1% (-0.51ms - +0.20ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +4% (-0.36ms - +2.90ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -5% - +3% (-0.79ms - +0.54ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +4% (-0.65ms - +2.83ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +4% (-0.03ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +1% (-0.70ms - +0.15ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +1% (-0.67ms - +0.40ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +4% (-0.28ms - +0.58ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -6% - +1% (-0.06ms - +0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local909.39ms - 915.65ms-unsure 🔍
-1% - +0%
-4.94ms - +3.10ms
preact-main910.92ms - 915.95msunsure 🔍
-0% - +1%
-3.10ms - +4.94ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local26.75ms - 26.75ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main26.75ms - 26.75msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.60ms - 16.70ms-unsure 🔍
-3% - +1%
-0.51ms - +0.20ms
preact-main16.45ms - 17.16msunsure 🔍
-1% - +3%
-0.20ms - +0.51ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.75ms - 1.76ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.75ms - 1.76msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local76.72ms - 79.58ms-unsure 🔍
-0% - +4%
-0.36ms - +2.90ms
preact-main76.10ms - 77.66msunsure 🔍
-4% - +0%
-2.90ms - +0.36ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local14.34ms - 14.97ms-unsure 🔍
-2% - +4%
-0.28ms - +0.58ms
preact-main14.21ms - 14.79msunsure 🔍
-4% - +2%
-0.58ms - +0.28ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.38ms - 17.20ms-unsure 🔍
-5% - +3%
-0.79ms - +0.54ms
preact-main16.39ms - 17.44msunsure 🔍
-3% - +5%
-0.54ms - +0.79ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.86ms - 4.86ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main4.86ms - 4.86msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local70.86ms - 73.83ms-unsure 🔍
-1% - +4%
-0.65ms - +2.83ms
preact-main70.35ms - 72.16msunsure 🔍
-4% - +1%
-2.83ms - +0.65ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.67ms - 3.70ms-unsure 🔍
-1% - +1%
-0.02ms - +0.03ms
preact-main3.66ms - 3.70msunsure 🔍
-1% - +1%
-0.03ms - +0.02ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local28.14ms - 28.98ms-unsure 🔍
-3% - +1%
-0.93ms - +0.36ms
preact-main28.35ms - 29.33msunsure 🔍
-1% - +3%
-0.36ms - +0.93ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.30ms - 36.95ms-faster ✔
0% - 7%
0.05ms - 2.53ms
preact-main36.48ms - 38.35msslower ❌
0% - 7%
0.05ms - 2.53ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.69ms - 26.51ms-unsure 🔍
-1% - +2%
-0.29ms - +0.63ms
preact-main25.71ms - 26.15msunsure 🔍
-2% - +1%
-0.63ms - +0.29ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local24.03ms - 25.07ms-unsure 🔍
-2% - +3%
-0.53ms - +0.82ms
preact-main23.97ms - 24.84msunsure 🔍
-3% - +2%
-0.82ms - +0.53ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local28.80ms - 30.62ms-unsure 🔍
-4% - +5%
-1.22ms - +1.35ms
preact-main28.73ms - 30.56msunsure 🔍
-5% - +4%
-1.35ms - +1.22ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local23.45ms - 24.67ms-unsure 🔍
-5% - +1%
-1.32ms - +0.35ms
preact-main23.97ms - 25.12msunsure 🔍
-1% - +6%
-0.35ms - +1.32ms
-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.80ms - 1.87ms-unsure 🔍
-1% - +4%
-0.03ms - +0.08ms
preact-main1.77ms - 1.84msunsure 🔍
-4% - +1%
-0.08ms - +0.03ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.03ms - 1.08ms-unsure 🔍
-6% - +1%
-0.06ms - +0.01ms
preact-main1.06ms - 1.11msunsure 🔍
-1% - +6%
-0.01ms - +0.06ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.23ms - 28.66ms-unsure 🔍
-2% - +1%
-0.70ms - +0.15ms
preact-main28.35ms - 29.09msunsure 🔍
-1% - +2%
-0.15ms - +0.70ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.25ms - 1.25msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.66ms - 33.34ms-unsure 🔍
-2% - +1%
-0.67ms - +0.40ms
preact-main32.73ms - 33.56msunsure 🔍
-1% - +2%
-0.40ms - +0.67ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.69ms - 3.69ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main3.69ms - 3.69msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

github-actions bot commented Apr 29, 2024

Size Change: -132 B (0%)

Total Size: 60.9 kB

Filename Size Change
dist/preact.js 4.59 kB -23 B (0%)
dist/preact.min.js 4.62 kB -22 B (0%)
dist/preact.min.module.js 4.62 kB -23 B (0%)
dist/preact.min.umd.js 4.65 kB -22 B (0%)
dist/preact.module.js 4.6 kB -22 B (0%)
dist/preact.umd.js 4.66 kB -20 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4.09 kB 0 B
compat/dist/compat.module.js 4.01 kB 0 B
compat/dist/compat.umd.js 4.14 kB 0 B
debug/dist/debug.js 3.63 kB 0 B
debug/dist/debug.module.js 3.63 kB 0 B
debug/dist/debug.umd.js 3.71 kB 0 B
devtools/dist/devtools.js 230 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 976 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 949 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Apr 29, 2024

Coverage Status

coverage: 99.609%. remained the same
when pulling c084f43 on remove-replace-node
into 613cacc on main.

@JoviDeCroock JoviDeCroock changed the base branch from main to breaking-changes-11 April 30, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants