Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(core): test perf of less arguments #4367

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

perf(core): test perf of less arguments #4367

wants to merge 5 commits into from
+11 −6

Conversation

JoviDeCroock
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +2% (-11.27ms - +17.88ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +1% (-0.36ms - +0.14ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-1.25ms - +0.49ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -4% - +4% (-0.59ms - +0.62ms)
    preact-local vs preact-main
  • replace1k: slower ❌ 0% - 4% (0.02ms - 2.57ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +5% (-0.05ms - +0.10ms)
    preact-local vs preact-main
  • todo: slower ❌ 0% - 2% (0.03ms - 0.62ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +0% (-0.47ms - +0.11ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +1% (-0.61ms - +0.20ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.03ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local895.29ms - 916.44ms-unsure 🔍
-1% - +2%
-11.27ms - +17.88ms
preact-main892.53ms - 912.60msunsure 🔍
-2% - +1%
-17.88ms - +11.27ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local27.31ms - 27.31ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main27.30ms - 27.31msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.64ms - 16.78ms-unsure 🔍
-2% - +1%
-0.36ms - +0.14ms
preact-main16.58ms - 17.06msunsure 🔍
-1% - +2%
-0.14ms - +0.36ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.76ms - 1.76ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.76ms - 1.76msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local79.36ms - 80.69ms-unsure 🔍
-2% - +1%
-1.25ms - +0.49ms
preact-main79.84ms - 80.97msunsure 🔍
-1% - +2%
-0.49ms - +1.25ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local14.26ms - 14.74ms-unsure 🔍
-4% - +1%
-0.61ms - +0.20ms
preact-main14.38ms - 15.04msunsure 🔍
-1% - +4%
-0.20ms - +0.61ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local14.75ms - 15.33ms-unsure 🔍
-4% - +4%
-0.59ms - +0.62ms
preact-main14.50ms - 15.55msunsure 🔍
-4% - +4%
-0.62ms - +0.59ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.94ms - 4.95ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main4.94ms - 4.95msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local70.90ms - 73.08ms-slower ❌
0% - 4%
0.02ms - 2.57ms
preact-main70.02ms - 71.36msfaster ✔
0% - 4%
0.02ms - 2.57ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.76ms - 3.80ms-unsure 🔍
-1% - +0%
-0.03ms - +0.02ms
preact-main3.77ms - 3.80msunsure 🔍
-0% - +1%
-0.02ms - +0.03ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local29.34ms - 30.02ms-unsure 🔍
-2% - +0%
-0.75ms - +0.12ms
preact-main29.72ms - 30.27msunsure 🔍
-0% - +3%
-0.12ms - +0.75ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local34.53ms - 36.31ms-unsure 🔍
-4% - +3%
-1.41ms - +1.01ms
preact-main34.81ms - 36.44msunsure 🔍
-3% - +4%
-1.01ms - +1.41ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local26.80ms - 27.23ms-unsure 🔍
-0% - +2%
-0.08ms - +0.52ms
preact-main26.59ms - 27.01msunsure 🔍
-2% - +0%
-0.52ms - +0.08ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.09ms - 25.86ms-unsure 🔍
-1% - +3%
-0.31ms - +0.79ms
preact-main24.84ms - 25.62msunsure 🔍
-3% - +1%
-0.79ms - +0.31ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local26.86ms - 28.25ms-unsure 🔍
-4% - +3%
-1.17ms - +0.79ms
preact-main27.06ms - 28.44msunsure 🔍
-3% - +4%
-0.79ms - +1.17ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local24.01ms - 25.11ms-unsure 🔍
-1% - +5%
-0.25ms - +1.15ms
preact-main23.67ms - 24.55msunsure 🔍
-5% - +1%
-1.15ms - +0.25ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.01ms - 2.10ms-unsure 🔍
-2% - +5%
-0.05ms - +0.10ms
preact-main1.98ms - 2.09msunsure 🔍
-5% - +2%
-0.10ms - +0.05ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 0.98ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main0.98ms - 0.98msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.46ms - 28.97ms-slower ❌
0% - 2%
0.03ms - 0.62ms
preact-main28.24ms - 28.55msfaster ✔
0% - 2%
0.03ms - 0.62ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.26ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.25ms - 1.25msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.90ms - 29.14ms-unsure 🔍
-2% - +0%
-0.47ms - +0.11ms
preact-main28.94ms - 29.47msunsure 🔍
-0% - +2%
-0.11ms - +0.47ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.74ms - 3.74ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main3.74ms - 3.74msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited

Size Change: +5 B (+0.01%)

Total Size: 61.5 kB

Filename Size Change
dist/preact.js 4.64 kB +3 B (+0.06%)
dist/preact.min.js 4.66 kB -2 B (-0.04%)
dist/preact.min.module.js 4.66 kB +1 B (+0.02%)
dist/preact.min.umd.js 4.69 kB -3 B (-0.06%)
dist/preact.module.js 4.66 kB +4 B (+0.09%)
dist/preact.umd.js 4.71 kB +2 B (+0.04%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.09 kB
compat/dist/compat.module.js 4.01 kB
compat/dist/compat.umd.js 4.14 kB
debug/dist/debug.js 3.71 kB
debug/dist/debug.module.js 3.71 kB
debug/dist/debug.umd.js 3.79 kB
devtools/dist/devtools.js 231 B
devtools/dist/devtools.module.js 240 B
devtools/dist/devtools.umd.js 314 B
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.module.js 1.59 kB
hooks/dist/hooks.umd.js 1.63 kB
jsx-runtime/dist/jsxRuntime.js 976 B
jsx-runtime/dist/jsxRuntime.module.js 949 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 453 B
test-utils/dist/testUtils.module.js 454 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Apr 30, 2024 •
edited

Coverage Status

coverage: 99.61%. remained the same
when pulling 79c9445 on test-perf-of-less-args
into 85bed33 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoviDeCroock @coveralls