Fix attributes diff on DOM node #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
reviewed
Apr 30, 2017
src/vdom/diff.js
Outdated
| @@ -124,6 +124,8 @@ function idiff(dom, vnode, context, mountAll, componentRoot) { | |||
| props = out[ATTR_KEY] || (out[ATTR_KEY] = {}), | |||
| vchildren = vnode.children; | |||
|
|
|||
| for (let a=out.attributes, i=a.length; i--; ) props[a[i].name] = a[i].value; | |||
There was a problem hiding this comment.
we'll need to wrap this in a check for props. If the propcache already exists on an element, skipping attribute checks is a fairly major performance gain.
There was a problem hiding this comment.
I'm fine doing this post-merge if you want.
Added the Periodic Weather PWA with the lastest of Preact to the list! ☀️
|
@developit code updated to loop over attributes only when not cached : https://github.com/developit/preact/pull/677/files#diff-a0896fa5d65b1d80ca4d496badbae50fR127 |
developit
approved these changes
May 25, 2017
| props = out[ATTR_KEY]; | ||
| } | ||
| else { | ||
| props = out[ATTR_KEY] = {}; |
There was a problem hiding this comment.
I'll probably consolidate this post-merge, but it's good!
developit
added a commit
that referenced
this pull request
Jun 3, 2017
|
Hi @developit, is there a planned release with this fix ? |
|
Yup, 8.2 out soon. |
|
@developit would love that release! |
|
Me too, heh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behaviour
Diff should remove attributes when they are no longer present in the next html state (see unit test)
Actual behaviour
It behaves as expected when the merged node is created using
h.It preserves removed attributes when the merged node comes from the DOM.
Possible solutions