Add prepublishOnly script #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
reviewed
Aug 23, 2017
config/prepublish.js
Outdated
| 'eslintConfig' | ||
| ]; | ||
|
|
||
| UNNECESSARY_KEYS.forEach(key => delete pkg[key]); |
There was a problem hiding this comment.
probably best to keep this as a normal function to support Node 6
|
Changes Unknown when pulling 5381232 on rubenmoya:820-add-prepublish-script into ** on developit:master**. |
rmacklin
added a commit
to rmacklin/preact
that referenced
this pull request
Aug 26, 2017
This reverts commit 5645573. Unfortunately, this prepublishOnly script wasn't working properly. The published package.json was still including the properties that were supposed to be stripped out by this script, as seen here: https://unpkg.com/preact@8.2.4/package.json So instead, to solve preactjs#820, we moved the babel settings to a .babelrc which is not included in the published package: d6ab85c Thus, we can remove this prepublishOnly script
developit
pushed a commit
that referenced
this pull request
Aug 26, 2017
This reverts commit 5645573. Unfortunately, this prepublishOnly script wasn't working properly. The published package.json was still including the properties that were supposed to be stripped out by this script, as seen here: https://unpkg.com/preact@8.2.4/package.json So instead, to solve #820, we moved the babel settings to a .babelrc which is not included in the published package: d6ab85c Thus, we can remove this prepublishOnly script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #820
This PR adds a
prepublishOnlyscript which removes unnecessary keys from thepackage.json.Feedback is welcome :)