Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disposing currently running effects #170

Merged
merged 3 commits into from
Sep 18, 2022
Merged

Allow disposing currently running effects #170

merged 3 commits into from
Sep 18, 2022

Conversation

jviide
Copy link
Contributor

@jviide jviide commented Sep 17, 2022

This pull request adds the support for disposing currently running effects. The reasoning for this is that it's convenient, and ends up saving a couple of bytes in some bundle versions.

Disposing the effect while running just delays the full disposal until the run has finished.

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2022

🦋 Changeset detected

Latest commit: 3e31aab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 17, 2022

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 3e31aab
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/632673354282cf0008ca0dee
😎 Deploy Preview https://deploy-preview-170--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2022

Size Change: +26 B (0%)

Total Size: 68 kB

Filename Size Change
docs/dist/assets/client.********.js 45.8 kB +1 B (0%)
docs/dist/assets/index.********.js 1.08 kB +3 B (0%)
docs/dist/assets/signals-core.module.********.js 1.59 kB -3 B (0%)
docs/dist/assets/signals.module.********.js 1.97 kB +6 B (0%)
docs/dist/basic-********.js 246 B +2 B (+1%)
docs/dist/demos-********.js 3.35 kB +1 B (0%)
docs/dist/nesting-********.js 1.13 kB +3 B (0%)
docs/dist/react-********.js 240 B +3 B (+1%)
packages/core/dist/signals-core.js 1.63 kB -4 B (0%)
packages/core/dist/signals-core.mjs 1.31 kB +14 B (+1%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/jsxRuntime.module.********.js 282 B
docs/dist/assets/preact.module.********.js 4 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
packages/preact/dist/signals.js 1.2 kB
packages/preact/dist/signals.mjs 1.18 kB
packages/react/dist/signals.js 860 B
packages/react/dist/signals.mjs 840 B

compressed-size-action

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice

@marvinhagemeister
Copy link
Member

@jviide feel free to add a changeset for this. I think it's worthy enough to be part of the release notes 💯

@jviide jviide merged commit 6428214 into main Sep 18, 2022
@jviide jviide deleted the dead-effect-walking branch September 18, 2022 01:29
@github-actions github-actions bot mentioned this pull request Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants