-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disposing currently running effects #170
Conversation
🦋 Changeset detectedLatest commit: 3e31aab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Size Change: +26 B (0%) Total Size: 68 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niice
@jviide feel free to add a changeset for this. I think it's worthy enough to be part of the release notes 💯 |
This pull request adds the support for disposing currently running effects. The reasoning for this is that it's convenient, and ends up saving a couple of bytes in some bundle versions.
Disposing the effect while running just delays the full disposal until the run has finished.