Fix preact-iso intercepting cmd/ctrl + click

preactjs · Sep 2, 2021 · 21bbeb9 · 21bbeb9
1 parent 1790e0f
commit 21bbeb9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.changeset/strange-dolphins-walk.md b/.changeset/strange-dolphins-walk.md
@@ -0,0 +1,5 @@
+---
+'preact-iso': patch
+---
+
+Fix `preact-iso` intercepting `cmd/ctrl+click` and other native browser behaviors.
diff --git a/packages/preact-iso/router.js b/packages/preact-iso/router.js
@@ -5,6 +5,11 @@ let push;
 const UPDATE = (state, url) => {
 	push = undefined;
 	if (url && url.type === 'click') {
+		// ignore events the browser takes care of already:
+		if (url.ctrlKey || url.metaKey || url.altKey || url.shiftKey || url.button !== 0) {
+			return;
+		}
+
 		const link = url.target.closest('a[href]');
 		if (
 			!link ||