Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@rollup/plugin-strip issue with include/exclude options in windows #456

Open
patak-dev opened this issue Mar 21, 2021 · 0 comments
Open
Labels
bug Something isn't working

Comments

@patak-dev
Copy link

We discussed a bit today with @marvinhagemeister in Vite Land.

Describe the bug

This is a Windows only compat issue that we also run into in Vite.

This is the equivalent issue report in Vite: vitejs/vite#1522 (comment)
And this the PR to fix it vitejs/vite#1693, avoiding the removal of the volume unit (C:) in Windows.

You can check the default pattern for include in the plugin, that should match index.js
https://github.com/rollup/plugins/tree/master/packages/strip#include

This is not only an issue for @rollup/plugin-strip, but for all other plugins using createFilter from rollup utils.

To Reproduce

Steps to reproduce the behavior:

  1. Clone repro https://github.com/matias-capeletto/wmr-rollup-plugin-strip
  2. yarn then, yarn dev or yarn build
  3. console.log("this should be removed") should be removed in dev and prod

Expected behavior

The common createFilter pattern (include/exclude) used in rollup plugins should be supported.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: n/a
  • WMR Version v1.3.2

Additional context

We have a rollup plugin compat label in the Vite Repo. Other issues that we encountered may be present in WMR https://github.com/vitejs/vite/issues?q=is%3Aissue+label%3A%22rollup+plugin+compat%22+

For reference, I'm maintaining a Vite compatibility list for rollup plugins here https://vite-rollup-plugins.patak.dev/

@patak-dev patak-dev added the bug Something isn't working label Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant