You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a Windows only compat issue that we also run into in Vite.
This is the equivalent issue report in Vite: vitejs/vite#1522 (comment)
And this the PR to fix it vitejs/vite#1693, avoiding the removal of the volume unit (C:) in Windows.
We discussed a bit today with @marvinhagemeister in Vite Land.
Describe the bug
This is a Windows only compat issue that we also run into in Vite.
This is the equivalent issue report in Vite: vitejs/vite#1522 (comment)
And this the PR to fix it vitejs/vite#1693, avoiding the removal of the volume unit (
C:
) in Windows.You can check the default pattern for
include
in the plugin, that should matchindex.js
https://github.com/rollup/plugins/tree/master/packages/strip#include
This is not only an issue for @rollup/plugin-strip, but for all other plugins using
createFilter
from rollup utils.To Reproduce
Steps to reproduce the behavior:
yarn
then,yarn dev
oryarn build
console.log("this should be removed")
should be removed in dev and prodExpected behavior
The common
createFilter
pattern (include/exclude) used in rollup plugins should be supported.Desktop (please complete the following information):
Additional context
We have a
rollup plugin compat
label in the Vite Repo. Other issues that we encountered may be present in WMR https://github.com/vitejs/vite/issues?q=is%3Aissue+label%3A%22rollup+plugin+compat%22+For reference, I'm maintaining a Vite compatibility list for rollup plugins here https://vite-rollup-plugins.patak.dev/
The text was updated successfully, but these errors were encountered: