Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing .dist/ to dist/ #73

Closed
marvinhagemeister opened this issue Jul 21, 2020 · 1 comment · Fixed by #82
Closed

Consider changing .dist/ to dist/ #73

marvinhagemeister opened this issue Jul 21, 2020 · 1 comment · Fixed by #82

Comments

@marvinhagemeister
Copy link
Member

The most popular way according to GitHub stars is to copy & paste one from https://github.com/github/gitignore/blob/master/Node.gitignore . There is even a vscode plugin for that, that does this (I'm using it myself quite heavily). It ignores dist/ by default.

I know we went a bit back and forth on naming it dist/ vs .dist/ but the former arguable removes a friction point for users. Let's not repeat the same mistake in microbundle of requiring users to extend their .gitignore.

@developit
Copy link
Member

The trick here is that currently dist/ is used for production output, whereas .dist is used for static files generated during development. Because one is unbundled and the other bundled, they're a very different set of files.

Looking at the gitignore you linked, maybe we could use .cache as the development output directory? That's essentially what the disk files are used as, they're never served directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants