Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Streamlined Buyer and Brand Id's #3115

Closed
Slind14 opened this issue Sep 21, 2018 · 33 comments
Closed

[Feature] Streamlined Buyer and Brand Id's #3115

Slind14 opened this issue Sep 21, 2018 · 33 comments
Assignees
Labels

Comments

@Slind14
Copy link
Contributor

Slind14 commented Sep 21, 2018

Feature

From a publisher perspective it would be great to get access to the buyer and brand id's. A couple of major exchanges (AppNexus, Rubicon, Index..) are already exposing this data but do not follow a common syntax.

Current Situation:

AppNexus (1.x pbjs bid object)
image
Rubicon (1.x pbjs bid object)
image
Index (bid respond, not transmitted to pbjs bid object)
image

Proposal

Major/Minor Version
Optional streamlined/restful declaration for buyer, brand, landing page domain and additional dynamic information.
Breaking Version (2.0)
Network, Agency, Buyer, Brand and primaryCatId become mandatory.

Could look like:

meta: {
    networkId: 34,                          // Network/DSP Id
    networkName: 'Adform'                   // Network/DSP Name
    agencyId: 0,                            // Agency Id
    agencyName: 'direct',                   // Agency Name
    buyerId: 4994,                          // Buyer/Advertiser
    buyerName: 'Volvo',                     // Buyer/Advertiser Name
    brandId: 39342,                         // Brand/Product
    brandName: 'Volvo v40',                 // Brand/Product Name
    primaryCatId: 'IAB2',                   // Primary IAB Sub Category ID
    secondaryCatIds: ['IAB2-3'],            // Secondary IAB Sub Category IDs
    clickUrl: 'https://www.volvocars.com/nl/modellen/model/v40'   // landing page
}

Open to discussions

Are there any other variables/meta information which would/could be valuable for you?

@mkendall07
Copy link
Member

Probably should rename domain to clickUrl since that's closer to the industry name.

@Slind14
Copy link
Contributor Author

Slind14 commented Sep 24, 2018

Probably should rename domain to clickUrl since that's closer to the industry name.

Does clickUrl always refer to the "landing page" or to the tracking pages in between as well?

@mkendall07
Copy link
Member

It depends. Some SSPs will use 2 separate URLS and some combine them (daisy chains style).

@Slind14
Copy link
Contributor Author

Slind14 commented Nov 9, 2018

Updated split buyer into buyer and network. AppNexus reports both under buyer and most other exchanges report them separately. We want the lowest level of granularity and aggregate it on pub side if needed.

@Slind14
Copy link
Contributor Author

Slind14 commented Nov 9, 2018

Updated added IAB Category ID

@mkendall07
Copy link
Member

@Slind14
I updated it a bit. Let me know what you think. I dropped creativeId and DealId because they already exist on bid and I don't think we need to make a breaking change just to move them.

@Slind14
Copy link
Contributor Author

Slind14 commented Nov 21, 2018

Looking good. I have added network name for convince. For clarity and order I think it could be of benefit to include the deal and creative id in the meta data, be it by keeping a duplicate in the parent object or depreciating the duplicate with the next breaking version.

@chefbenjamin
Copy link

This is a great addition. coming from the publisher side, what are the chances this info can be added into the bids and winning bids scripts ? ie http://prebid.org/dev-docs/troubleshooting-tips.html#see-all-bids-in-the-console and http://prebid.org/dev-docs/troubleshooting-tips.html#see-all-winning-bids-in-the-console The ability to see this would help a great deal in previewing bad creatives and blocking crappy buyers within each of the SSP.

@Slind14
Copy link
Contributor Author

Slind14 commented Nov 23, 2018

what are the chances this info can be added into the bids and winning bids scripts

A small addition to the script and you would be set. Though I highly recommend recording the data so you can track down and block bad ads more easily.

@kelvin-chappell
Copy link
Contributor

It would be helpful to distinguish between advertiser and agency, where that information is available. So:

buyerId: 4994,                   // Advertiser/Agency
buyerName: 'name',               // Buyer Name

might become:

agencyId: 4993,
agencyName: 'agName',
advertiserId: 4994, 
advertiserName: 'adName',

Would that be feasible?

kelvin-chappell added a commit to guardian/Prebid.js that referenced this issue Feb 15, 2019
kelvin-chappell added a commit to guardian/Prebid.js that referenced this issue Feb 15, 2019
Assuming that bid response has buyer data in format specified in
prebid#3115
kelvin-chappell added a commit to guardian/Prebid.js that referenced this issue Feb 25, 2019
kelvin-chappell added a commit to guardian/Prebid.js that referenced this issue Mar 12, 2019
@Slind14
Copy link
Contributor Author

Slind14 commented Mar 13, 2019

@kelvin-chappell updated it to reflect the additional dimension and added a simple example

@mkendall07
Copy link
Member

Small update to match what we did for the long form video competitive separation.

mkendall07 pushed a commit that referenced this issue Mar 26, 2019
pycnvr pushed a commit to conversant/Prebid.js that referenced this issue Apr 4, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this issue May 15, 2019
@bretg
Copy link
Collaborator

bretg commented Apr 12, 2020

ok, please take a look at https://prebid.org/dev-docs/bidder-adaptor.html and search for meta. Not much but it's a start. Should IAB categories be strings prefixed with "IAB-" or just integers?

@Slind14
Copy link
Contributor Author

Slind14 commented Apr 12, 2020

Looks good. Thank you.

@bretg
Copy link
Collaborator

bretg commented Apr 24, 2020

Also updated the server-side bidder adapter page -- http://lh.prebid.org:8080/prebid-server/developers/add-new-bidder.html#bid-response-metadata

FilipStamenkovic pushed a commit that referenced this issue Jun 23, 2020
* add adomain to bid.meta in spotx adapter


this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for SpotX

* Update spotxBidAdapter.js

* Update spotxBidAdapter.js

* unit test for adomain on spotx adapter

* Update spotxBidAdapter_spec.js

* Update spotxBidAdapter_spec.js
@patmmccann patmmccann mentioned this issue Jun 24, 2020
2 tasks
mike-chowla pushed a commit that referenced this issue Jun 29, 2020
* add adomain to bid.meta in telaria adapter

this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for Telaria
@patmmccann patmmccann mentioned this issue Jul 3, 2020
2 tasks
jsnellbaker added a commit that referenced this issue Jul 23, 2020
* remove these adapters from 4.0 (#5369)

Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>

* add meta key to interpreted bid response (#5358)

* add meta key to interpreted bid response

* add more unit tests

Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>

* add adomain to bid.meta in spotx adapter (#5401)

* add adomain to bid.meta in spotx adapter


this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for SpotX

* Update spotxBidAdapter.js

* Update spotxBidAdapter.js

* unit test for adomain on spotx adapter

* Update spotxBidAdapter_spec.js

* Update spotxBidAdapter_spec.js

* adds advertiserDomains meta to the pubmatic adapter (#5402)

* adds advertiserDomains meta

* Update pubmaticBidAdapter.js

* unit test for meta.advertiserDomains to pubmatic

* Update pubmaticBidAdapter_spec.js

* TCF Purpose 1 and Purpose 2 enforcement for Prebid v4.0 (#5336)

* TCF v2.0 enforcement

* test/spec/modules/gdprEnforcement_spec.js

* add check for gdpr version

* add logInfo message

* remove comment and store value of PURPOSES in an object

* add gvlid check

* add unit tests for validateRules function

* remove purposeId parameter from validateRules function

* add extra tests

* make failing unit test case pass

* deprecate allowAuctionWithouConsent with tcf 2 workflow

* add extra checks for defaults

* remove tcf 2 test page

* add strict gvlid check

* add comments and shorten log messages

* shorted log messages

* add unit tests for setEnforcementConfig

* add gvlid for alias and gvlMapping support

* remove gvlid check

* add support to add gvlid for aliases

Co-authored-by: Jaimin Panchal <email@example.com>

* add advertiserDomains meta field to ix adapter (#5404)

* add advertiserDomains meta field to ix adapter

* Update ixBidAdapter.js

* Update ixBidAdapter_spec.js

* Update ixBidAdapter_spec.js

* add adomain to bid.meta in telaria adapter (#5400)

* add adomain to bid.meta in telaria adapter

this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for Telaria

* Remove digitrust from prebid server js adapter (#5438)

* Update prebidServerBidAdapter_spec.js

* Update index.js

* Interactive advertising bureau digitrust exit (#5429)

* Removing DigiTrust ID system core.

* Removing test spec for digitrust id.

* Removing DigiTrust references from eids test spec.

Co-authored-by: Chris Cole <goosemanjack@gmail.com>

* Delete serverbidBidAdapter.md (#5477)

deprecated in favor of consumable adapter

* Set cookie domain in pubcid / userid on main domain, not subdomain (#5500)

* update formatting

* update formatting

* requested changes implemented

* add unit test

* add test case for missing adomain in ix adapter (#5422)

* add test case for missing adomain in ix adapter

at request of @ix-prebid-support on #5404

* Update ixBidAdapter_spec.js

* Update ixBidAdapter_spec.js

* Update ixBidAdapter_spec.js

* drop support for userId configs with the `usersync` config object (#5427)

* drop support for userId configs with the `usersync` config object, per deprecation notice

* changes on drop support (#1)

* Update userIdTargeting.md

* Update userId.md

* Update userId_spec.js

* Update britepoolIdSystem.md

* Update sharedIdSystem.md

Co-authored-by: Patrick McCann <patmmccann@gmail.com>

Co-authored-by: sumit sharma <sharmasumit116@gmail.com>
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: Jaimin Panchal <email@example.com>
Co-authored-by: Neelanjan Sen <neelanjan.sen@gmail.com>
Co-authored-by: Chris Cole <goosemanjack@gmail.com>
Co-authored-by: Isaac A. Dettman <idettman@rubiconproject.com>
Co-authored-by: Scott <smenzer@gmail.com>
@bretg
Copy link
Collaborator

bretg commented Feb 8, 2021

@Slind14 - we'd like to propose closing out this issue:

  1. The PBJS bidder documentation encourages adapters to define these values on the bidresponse https://docs.prebid.org/dev-docs/bidder-adaptor.html
  2. Same with the PBS bidder docs - https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html
  3. @gglas is going to open a separate issue to allow publishers to configure whether a certain piece of metadata is required for accepting bid responses.

Do you agree this can be closed, working the enforcement in a separate issue?

@Slind14
Copy link
Contributor Author

Slind14 commented Feb 10, 2021

Thank you, @bretg

Is there any chance that it can be made mandatory with the next breaking release?

@bretg
Copy link
Collaborator

bretg commented Feb 10, 2021

@Slind14 - we're going to make it optional for publishers to configure whether they want to enforce certain fields for certain bidders. Prebid is not in a position to push the entire industry to supply metadata.

It's conceivable that such opt-in behavior could become default in the distant future.

@ChrisHuie
Copy link
Collaborator

closing and moving to #6453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants