Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new boldwin bid adapter #5454

Merged
merged 5 commits into from Jul 23, 2020
Merged

new boldwin bid adapter #5454

merged 5 commits into from Jul 23, 2020

Conversation

Wls-demo
Copy link
Contributor

@Wls-demo Wls-demo commented Jul 3, 2020

Type of change

  • New bidder adapter
  • test parameters for validating bids
{
  bidder: 'trendqube',
                            params: {
                                placementId: 0,
                                traffic: 'video'
                            }
}
{
                            bidder: 'trendqube',
                            params: {
                                placementId: 0,
                                traffic: 'banner'
                            }
                        }

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@patmmccann
Copy link
Collaborator

patmmccann commented Jul 3, 2020

can you copy bid.clickurl domain to bid.meta.advertiserDomains and any other applicable meta domains? see #3115 and http://prebid.org/dev-docs/bidder-adaptor.html#interpreting-the-response

@Wls-demo
Copy link
Contributor Author

Wls-demo commented Jul 5, 2020

@patmmccann I've added meta with advert domains

@Wls-demo
Copy link
Contributor Author

Wls-demo commented Jul 8, 2020

@patmmccann Good day to you, is there any updates? If thecase in failing circle ci - the problem in another adapter

@patmmccann
Copy link
Collaborator

I'm not the assigned reviewer; we just have buyer transparency as an initiative that widespread support for meta.AD is the first step of.

@Wls-demo
Copy link
Contributor Author

@mike-chowla Good day to you, is everything fine? Can you, please, close review

@Adprime
Copy link
Contributor

Adprime commented Jul 22, 2020

@jaiminpanchal27 Good day to you, can i please ask you to assignee another reviewer to close this PR, because current seems have no activity since 14 of july

@mike-chowla
Copy link
Contributor

mike-chowla commented Jul 22, 2020 via email

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 34ea366 into prebid:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants