Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kargo Adapter: Add request timestamp #2664

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Kargo Adapter: Add request timestamp #2664

merged 1 commit into from
Jun 22, 2018

Conversation

samuelhorwitz
Copy link
Contributor

@samuelhorwitz samuelhorwitz commented May 31, 2018

Type of change

  • Feature

Description of change

We want to log the browser's timestamp of when the request was made.

We also are fixing a minor casing issue that doesn't cause issues with our Golang JSON unmarshaling but should be standardized on principle to our canonical name

@samuelhorwitz samuelhorwitz changed the title add request timestamp Kargo adapter: add request timestamp May 31, 2018
@samuelhorwitz samuelhorwitz changed the title Kargo adapter: add request timestamp Kargo Adapter: Add request timestamp May 31, 2018
@stale
Copy link

stale bot commented Jun 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 15, 2018
Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need a test for the new param and need to fix the existing test for the param that changed (travis-ci tests are failing)

@samuelhorwitz
Copy link
Contributor Author

Whoops, done

@harpere harpere merged commit 30f7665 into prebid:master Jun 22, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants