EMX Digital: Device info and Video parameter updates #3929
Conversation
|
We are not sure why this test is failing when submitting this PR. All tests pass when we run locally, please advise. |
|
This pull request introduces 1 alert when merging 6e86a03 into ce095e0 - view on LGTM.com new alerts:
This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
There was a problem hiding this comment.
Hi @EMXDigital
I took a look through the updates. They largely seem good, though there are some items that need to be addressed. I saw you were making some changes already, so you may already be working on it.
Please let me know if you have any questions. Thanks!
modules/emx_digitalBidAdapter.js
Outdated
| secure: networkProtocol | ||
| tagid, | ||
| secure, | ||
| ...(bidfloor > 0 && { bidfloor, bidfloorcur: DEFAULT_CUR }) |
There was a problem hiding this comment.
Using the spread operator like this isn't currently supported (this is what was causing the circleci browserstack test to fail during the original submission; spread is not supported in IE). Can you please refactor this part of the code?
There was a problem hiding this comment.
Thank you for pointing this out -- we've pushed a refactor in our latest commit.
modules/emx_digitalBidAdapter.js
Outdated
| let emxImps = []; | ||
| const timeout = config.getConfig('bidderTimeout'); | ||
| const emxImps = []; | ||
| const timeout = bidderRequest.timeout || ""; |
There was a problem hiding this comment.
Should use single-quotes instead double-quotes. This will fix the lint error.
There was a problem hiding this comment.
Done -- thank you
* EMX Digital - device info and video parameter updates * update timeout value to grab from bidderRequest arg * removing unused import * removing object spread use. quote fix for lint * remove space
* EMX Digital - device info and video parameter updates * update timeout value to grab from bidderRequest arg * removing unused import * removing object spread use. quote fix for lint * remove space
Type of change
Description of change
Include device & cur, catches for adm decode, include mediaType video params, and styling updates.