OpenX: Analytics Adapter update #5449
Conversation
|
This pull request introduces 1 alert when merging ed9e6b6 into 8c87a9e - view on LGTM.com new alerts:
|
jimee02
force-pushed
the
analytics-adapter-update
branch
from
ed9e6b6
to
b5b5b03
Compare
| } | ||
|
|
||
| /** | ||
| * @typedef {Object} PbBidRequest |
There was a problem hiding this comment.
I started defining the PB objects for consistency. Let me know if I should rename PBBidRequest and PbBidderRequest` to avoid conflicts.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@jaiminpanchal27, is it possible to reopen this PR? |
|
@mike-chowla, can you reopen this ticket? |
jsnellbaker
requested review from
jsnellbaker
and removed request for
jaiminpanchal27
|
Hi @jsnellbaker, I know this is a huge change. How do I make this easier for you? |
|
Hi @jimee02 I just pulled this PR to me and I plan to start taking a look at it today. So I'm not sure if there's anything particular as of yet. But I will try to follow-up soon (with either feedback, questions, or both). |
There was a problem hiding this comment.
Hi @jimee02
I reviewed the changes and I think on the whole everything looks fine. There were some minor suggestions though (the pubads() more recommended of the two), so please take a look when you have the chance.
In terms of testing the analytics adatper, are the sample values in the .md file still accurate to use? Or are there some new values I should use instead?
Thanks.
There was a problem hiding this comment.
I missed this part at first, but on further review, there is another set of items that need to be addressed.
There are a series of references to the find function in the unit tests that need to be updated to use the polyfill version of find so that the tests can run successfully in all browsers.
I highlighted one example below but there are a handful of other places in the tests. Please take a look through the test file and update all the areas needed.
Thanks again.
jimee02
force-pushed
the
analytics-adapter-update
branch
from
b5b5b03
to
ac03d5c
Compare
jimee02
force-pushed
the
analytics-adapter-update
branch
from
ac03d5c
to
15dea30
Compare
|
Hi @jsnellbaker, I just realized that the analytics documentation is outdated. The configuration options are accurate so I'm going to make the fixes to the readme in another PR because this one is already big enough. Thank you for taking the time to review this! Much appreciated. |
This reverts commit 1f43d7f.
Description of change
Rebuild of OpenX's Analytics adapter