Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lunamedia ad size parameter update #5490

Merged
merged 11 commits into from Jul 20, 2020
Merged

Conversation

trchandraprakash
Copy link
Contributor

@trchandraprakash trchandraprakash commented Jul 14, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Chandra Prakash and others added 10 commits March 16, 2019 23:41
update prebid.js code base from fork
LunaMedia Adapater
Accept size parameters
Adding a new line.

home/circleci/Prebid.js/modules/lunamediaBidAdapter.js

  401:22  error  Newline required at end of file but not found  eol-last

✖ 1 problem (1 error, 0 warnings)

  1 error, 0 warnings potentially fixable with the `--fix` option.
@trchandraprakash
Copy link
Contributor Author

Hi Guys, Can you please let me know if all good here and when i can make it available for clients. Thanks

modules/lunamediaBidAdapter.js Outdated Show resolved Hide resolved
modules/lunamediaBidAdapter.js Outdated Show resolved Hide resolved
modules/lunamediaBidAdapter.md Outdated Show resolved Hide resolved
updated as per review
@msm0504 msm0504 added LGTM and removed needs review labels Jul 20, 2020
@msm0504 msm0504 merged commit c56a03f into prebid:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants