Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lunamedia ad size parameter update #5490

Merged
merged 11 commits into from
Jul 20, 2020
Merged

Lunamedia ad size parameter update #5490

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d2db964
Update Bidder Code
Mar 17, 2019
3b5482a
Merge pull request #1 from prebid/master
trchandraprakash Apr 10, 2020
dd5accd
LunaMedia Adapater
Apr 11, 2020
774ef6c
Updated LunamediaBidAdapter.md test params and valid pub code for tes…
Apr 21, 2020
de37f22
adding it to resolve conflict in locally repo
Jul 13, 2020
fb92238
Merge branch 'master' into pr/3
trchandraprakash Jul 13, 2020
d75ecbd
Merge pull request #4 from trchandraprakash/pr/3
trchandraprakash Jul 13, 2020
6ac5d67
Merge pull request #3 from prebid/master
trchandraprakash Jul 13, 2020
e448229
Accept size parameters
Jul 14, 2020
1073983
Based on browserstack testing result
Jul 14, 2020
48ab9f2
updated as per review
Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 24 additions & 6 deletions modules/lunamediaBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import includes from 'core-js-pure/features/array/includes.js';
const ADAPTER_VERSION = '1.0';
const BIDDER_CODE = 'lunamedia';

export const VIDEO_ENDPOINT = 'https://api.lunamedia.io/xp/get?pubid=';// 0cf8d6d643e13d86a5b6374148a4afac';
export const BANNER_ENDPOINT = 'https://api.lunamedia.io/xp/get?pubid=';// 0cf8d6d643e13d86a5b6374148a4afac';
export const VIDEO_ENDPOINT = 'https://nep.advangelists.com/xp/get?pubid=';// https://api.lunamedia.io/xp/get?pubid=0cf8d6d643e13d86a5b6374148a4afac';
export const BANNER_ENDPOINT = 'https://nep.advangelists.com/xp/get?pubid=';// 0cf8d6d643e13d86a5b6374148a4afac';
export const OUTSTREAM_SRC = 'https://player-cdn.beachfrontmedia.com/playerapi/loader/outstream.js';
export const VIDEO_TARGETING = ['mimes', 'playbackmethod', 'maxduration', 'skip'];
export const DEFAULT_MIMES = ['video/mp4', 'application/javascript'];
Expand Down Expand Up @@ -44,6 +44,7 @@ export const spec = {

bannerBids.forEach(bid => {
pubid = getBannerBidParam(bid, 'pubid');

requests.push({
method: 'POST',
url: BANNER_ENDPOINT + pubid,
Expand Down Expand Up @@ -210,8 +211,18 @@ function createVideoRequestData(bid, bidderRequest) {
let topLocation = getTopWindowLocation(bidderRequest);
let topReferrer = getTopWindowReferrer();

let sizes = getVideoSizes(bid);
let firstSize = getFirstSize(sizes);
// if size is explicitly given via adapter params
var paramSize = getVideoBidParam(bid, 'size');
msm0504 marked this conversation as resolved.
Show resolved Hide resolved

var firstSize = [];
var sizes = [];

if (typeof paramSize !== 'undefined' && paramSize != '') {
sizes = parseSizes(paramSize);
} else {
sizes = getVideoSizes(bid);
}
firstSize = getFirstSize(sizes);
msm0504 marked this conversation as resolved.
Show resolved Hide resolved

let video = getVideoTargetingParams(bid);
const o = {
Expand Down Expand Up @@ -301,7 +312,15 @@ function createBannerRequestData(bid, bidderRequest) {
let topLocation = getTopWindowLocation(bidderRequest);
let topReferrer = getTopWindowReferrer();

let sizes = getBannerSizes(bid);
// if size is explicitly given via adapter params

var paramSize = getBannerBidParam(bid, 'size');
var sizes = [];
if (typeof paramSize !== 'undefined' && paramSize != '') {
sizes = parseSizes(paramSize);
} else {
sizes = getBannerSizes(bid);
}

const o = {
'device': {
Expand Down Expand Up @@ -379,5 +398,4 @@ function createBannerRequestData(bid, bidderRequest) {

return o;
}

registerBidder(spec);
6 changes: 4 additions & 2 deletions modules/lunamediaBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ var displayAdUnit = [
bidder: 'lunamedia',
params: {
pubid: '121ab139faf7ac67428a23f1d0a9a71b',
placement: 1234
placement: 1234,
size="320x50"
msm0504 marked this conversation as resolved.
Show resolved Hide resolved
}
}]
}];
Expand All @@ -52,7 +53,8 @@ var videoAdUnit = {
bidder: 'lunamedia',
params: {
pubid: '121ab139faf7ac67428a23f1d0a9a71b',
placement: 1234,
placement: 1234,
size="320x480",
video: {
id: 123,
skip: 1,
Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/lunamediaBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ describe('lunamediaBidAdapter', function () {
let bidRequestsVid;

beforeEach(function () {
bidRequests = [{'bidder': 'lunamedia', 'params': {'pubid': '0cf8d6d643e13d86a5b6374148a4afac', 'floor': 0.5, 'placement': 1234}, 'crumbs': {'pubcid': '979fde13-c71e-4ac2-98b7-28c90f99b449'}, 'mediaTypes': {'banner': {'sizes': [[300, 250]]}}, 'adUnitCode': 'div-gpt-ad-1460505748561-0', 'transactionId': 'f72931e6-2b0e-4e37-a2bc-1ea912141f81', 'sizes': [[300, 250]], 'bidId': '2aa73f571eaf29', 'bidderRequestId': '1bac84515a7af3', 'auctionId': '5dbc60fa-1aa1-41ce-9092-e6bbd4d478f7', 'src': 'client', 'bidRequestsCount': 1, 'pageurl': 'http://google.com'}];
bidRequests = [{'bidder': 'lunamedia', 'params': {'pubid': '0cf8d6d643e13d86a5b6374148a4afac', 'floor': 0.5, 'placement': 1234, size: '320x250'}, 'crumbs': {'pubcid': '979fde13-c71e-4ac2-98b7-28c90f99b449'}, 'mediaTypes': {'banner': {'sizes': [[300, 250]]}}, 'adUnitCode': 'div-gpt-ad-1460505748561-0', 'transactionId': 'f72931e6-2b0e-4e37-a2bc-1ea912141f81', 'sizes': [[300, 250]], 'bidId': '2aa73f571eaf29', 'bidderRequestId': '1bac84515a7af3', 'auctionId': '5dbc60fa-1aa1-41ce-9092-e6bbd4d478f7', 'src': 'client', 'bidRequestsCount': 1, 'pageurl': 'http://google.com'}];

bidRequestsVid = [{'bidder': 'lunamedia', 'params': {'pubid': '8537f00948fc37cc03c5f0f88e198a76', 'floor': 1.0, 'placement': 1234, 'video': {'id': 123, 'skip': 1, 'mimes': ['video/mp4', 'application/javascript'], 'playbackmethod': [2, 6], 'maxduration': 30}}, 'crumbs': {'pubcid': '979fde13-c71e-4ac2-98b7-28c90f99b449'}, 'mediaTypes': {'video': {'playerSize': [[320, 480]], 'context': 'instream'}}, 'adUnitCode': 'video1', 'transactionId': '8b060952-93f7-4863-af44-bb8796b97c42', 'sizes': [], 'bidId': '25c6ab92aa0e81', 'bidderRequestId': '1d420b73a013fc', 'auctionId': '9a69741c-34fb-474c-83e1-cfa003aaee17', 'src': 'client', 'bidRequestsCount': 1, 'pageurl': 'http://google.com'}];
bidRequestsVid = [{'bidder': 'lunamedia', 'params': {'pubid': '8537f00948fc37cc03c5f0f88e198a76', 'floor': 1.0, 'placement': 1234, size: '320x480', 'video': {'id': 123, 'skip': 1, 'mimes': ['video/mp4', 'application/javascript'], 'playbackmethod': [2, 6], 'maxduration': 30}}, 'crumbs': {'pubcid': '979fde13-c71e-4ac2-98b7-28c90f99b449'}, 'mediaTypes': {'video': {'playerSize': [[320, 480]], 'context': 'instream'}}, 'adUnitCode': 'video1', 'transactionId': '8b060952-93f7-4863-af44-bb8796b97c42', 'sizes': [], 'bidId': '25c6ab92aa0e81', 'bidderRequestId': '1d420b73a013fc', 'auctionId': '9a69741c-34fb-474c-83e1-cfa003aaee17', 'src': 'client', 'bidRequestsCount': 1, 'pageurl': 'http://google.com'}];
});

describe('spec.isBidRequestValid', function () {
Expand Down