Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synacormedia] Update bid url scheme #5665

Merged
merged 29 commits into from
Aug 31, 2020
Merged

Conversation

coreykress
Copy link
Contributor

Type of change

  • Bugfix

Description of change

This change updates the bid request scheme for requests to the technoratimedia ad server

Corey Kress and others added 29 commits February 5, 2020 17:00
* commit '25c5ad3b60ffd6b4d3c645dd9bf16bbb4397a346':
  CAP-1614 - updated docs to show correct size for banner and some other small fixes
* commit 'b6dfbc9a938563c2964d30719a78cde1f15d3740':
  CAP-1636 support schain object in prebid
* commit 'c934f2d341bea0938cd5b1b75e62030ce5447117':
  CAP-1636 updated the review comments
* commit 'a26077f86598287d5c7d2f624cd3fec5b0b8d3e1':
  CAP-1849 - split up banner and video impressions to use format
* commit 'c70d8fc30e44779a8f3f78fa341ad19ad1cf5395':
  CAP-1879 - added adapter support for consent management module
* commit '6fa31a1fb15b01dae836e70eae708dba1618adfb':
  CAP-1920 - fix a comparison, and height setting
  CAP-1920 - update tests and banner
  CAP-1920 - fixed size bug
* commit '74f7c5859c1bdb465fd781b900b1ec0319638f90':
  CAP-1966: Set hostname based on seat
  CAP-1966: Fix video impid parsing
@coreykress
Copy link
Contributor Author

The failing tests are from the Finteza and Pubmatic analytic adapters.

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertrmartinez robertrmartinez merged commit d642ebe into prebid:master Aug 31, 2020
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
* CAP-1614 - updated docs to show correct size for banner and some other small fixes

* CAP-1636 support schain object in prebid

* CAP-1636 updated the review comments

* CAP-1849 - split up banner and video impressions to use format

* CAP-1879 - added adapter support for consent management module

* CAP-1879 - updates for pr

* CAP-1879 - remove unneeded checks

* CAP-1920 - fixed size bug

* CAP-1920 - update tests and banner

* CAP-1920 - fix a comparison, and height setting

* CAP-1966: Fix video impid parsing

* CAP-1966: Set hostname based on seat

* CAP-1966 - update unit test

Co-authored-by: Corey Kress <corey.kress@synacor.com>
Co-authored-by: Rajkumar Natarajan <rajkumar.natarajan@synacor.com>
Co-authored-by: Lasse Saarinen <lsaarinen@synacor.com>
BrightMountainMediaInc added a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants