Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Optional Params to Concert Adapter #6064

Merged
merged 4 commits into from
Dec 4, 2020

Conversation

jeninedrew
Copy link
Contributor

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Add optional params to Concert adapter.

  • test parameters for validating bids
  var adUnits = [
    {
      code: 'desktop_leaderboard_variable',
      mediaTypes: {
        banner: {
          sizes: [[1030, 590]]
        }
      }
      bids: [
        {
          bidder: "concert",
          params: {
            partnerId: 'test_partner',
            site: 'site_name',
            placementId: 1234567,
            slot: 'slot_name',
            sizes: [[1030, 590]]
          }
        }
      ]
    }
  ];
}

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2020

This pull request introduces 4 alerts when merging 6ba431c into 6963bb3 - view on LGTM.com

new alerts:

  • 4 for Property access on null or undefined

@ncolletti ncolletti merged commit ddebc4a into prebid:master Dec 4, 2020
Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants