IX Bid Adapter: Use openrtb imp[].banner.format to build requests #7023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umakajan
changed the title
|
This pull request introduces 1 alert when merging c98a2c4 into dc6be1b - view on LGTM.com new alerts:
|
umakajan
force-pushed
the
IX-banner-format-support
branch
2 times, most recently
from
2653415
to
12831b2
Compare
|
This pull request introduces 1 alert when merging 12831b2 into dc6be1b - view on LGTM.com new alerts:
|
|
@umakajan looks like the remainingRequestSize variable is never used in the code. Is this variable needed or expected to be used soon for another implementation? |
umakajan
force-pushed
the
IX-banner-format-support
branch
2 times, most recently
from
a182d5d
to
8468ed0
Compare
umakajan
force-pushed
the
IX-banner-format-support
branch
from
80fc7b5
to
c619bee
Compare
|
@ChrisHuie @jsnellbaker this PR is ready for review now |
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
…ebid#7023) * use openrtb banner.format in request to cygnus * remove imp[].ext * update unit tests, removing imp[].ext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
In this PR, we are updating the
buildRequestfunction to build requests usingimp[].banner.format