Prebid Core: add AD_RENDER_SUCCEEDED event #7059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this enables interaction with the just rendered ad, as well as additional opportunities for measuring the speed of rendering code
ChrisHuie
changed the title
jsnellbaker
added
minor
needs 2nd review
msm0504
reviewed
Jun 21, 2021
msm0504
approved these changes
Jun 22, 2021
1 task
ChrisHuie
removed
minor
needs 2nd review
ChrisHuie
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This adds a new event, AD_RENDER_SUCCEEDED, which is emited by renderAd when rendering is successful. It also adds a test in the same manner as the tests that exist for AD_RENDER_FAILED.
doc patch: prebid/prebid.github.io#3045
Other information
This is related to work to enable #6909