Prebid Core: Update renderAd to use hook
#7091
Conversation
|
It seems like this could replace #7059. Hooks seem to be more flexible than the event system is, but perhaps there are trade offs I am not aware of? |
|
I think both make sense. Adding and using this hook delays the execution of the renderAd function until your piece of code finishes and calls it directly. This hook stuff is mainly used to alter and change things before the hooked function executes. The Event Library is more for notifying, and is non blocking. So I think both have a place, and AD_RENDER_SUCCEEDED seems like a valid event (Since there are times when a BID_WON Does not equal a Ad Successfully rendering) |
|
@iamnewton Will you pull latest master, there was a fix for a flaky test merged. |
There was a problem hiding this comment.
Looks fine.
I would like @snapwich to give his input since the hook library is his baby.
Rich, what are the impacts of adding this hook in the scenario where 99.9% of prebid wrappers will not actually register a hook.
What kind of overhead is there?
* master: Send screen size instead of browser size (#7110) Prebid Analytics Manager: extend mocha testing timeout to fix flaky ie test (#7104) IX Bid Adapter: Use openrtb imp[].banner.format to build requests (#7023) Sharethrough Bid Adapter: add support for GPID (#7089) VLYBY Bid Adapter: add new bid adapter (#6417) Fix the renderer tests so they can be run on their own (#7070) akamaiDAPIdSystem: add new ID submodule (#7084) Real Vu Analytics Adapter: update addUnitById() return value (#7088) rubicon adapter: segtax change (#7098) Pix Fixture Bid Adapter: add new bid adapter (#7069) Adkernel Bid Adapter: renaming converge alias (#7097) Dmd Id System: add rest endpoint (#7066) Added Media.net RTD Module (#6988) temporary dependency change and update a test eslintrc rule (#7094) increment pre version Prebid 5.2.0 Release
|
very little overhead. this should be fine. as for the event, hooks don't replace events; if you need the event i'd add that as well. |
|
@snapwich @robertrmartinez thanks for the context. |
robertrmartinez
changed the title
renderAd to use hookrenderAd to use hook
Type of change
Description of change
Updating
renderAdto use hook in preparation to use in a Fledge proposal test.