UserID: bugfix for refreshUserIds with updated info #7105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
changed the title
ChrisHuie
changed the title
Fawke
reviewed
Jul 9, 2021
There was a problem hiding this comment.
Hi @aaroniniguez, thank you for fixing this bug. Your changes look good to me, there's just an inline comment, see if we'd want to do that. Thanks.
Fawke
reviewed
Jul 9, 2021
Fawke
approved these changes
Jul 13, 2021
|
Adding @smenzer for a second review since it's a core change. |
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
* BugFix UserID module refreshUserIds * break from for loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
calling pbjs.refreshUserIds() with updated UserId info does not update adUnitBids (since addIdDataToAdUnitBids is passed in initializedSubmodules which is not updated by pbjs.refreshUserIds())
Other information
Fixes this issue:
#6783