QuantcastId : Add support for firing pixel in quantcastIdSystem submodule

[sachinsurfs]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

This introduces a callback function to send a pixel request to Quantcast servers once the document is loaded when the right configurations are provided and we have received the necessary consent. Please contact asig@quantcast.com for any issues.

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/ : QuantcastId : Update userID module documentation with the latest description and parameters prebid.github.io#3067

[ncolletti]

@sachinsurfs Could you provide a markdown file?

[sachinsurfs]

Hey @ncolletti - Done, I added a markdown file for the Quantcast Id System.

[ncolletti]

Should the firePixel callback within the load event be within the else block of the document.readyState? May help to prevent rare cases where both can fire as readyState is marked 'complete' right before the window 'load' event fires.

[sachinsurfs]

Like you mentioned, it is pretty rare since they ideally must happen at the same time. Regardless, I added an else block to be safe.

[ncolletti]

@sachinsurfs Please add your userId config to userId.md

[ncolletti]

There are tests failing on this PR, the first test within 'QuantcastId module' and four within the 'fire pixel' -- "quantcastIdSubmodule.findRootDomain is not a function".

[sachinsurfs]

@ncolletti - Regarding failed tests, can you tell me the steps you took to reproduce those errors? I found that gulp and browserstack tests on my machine and circleci are passing.

Testing on individual files like this -
gulp test --file "test/spec/modules/quantcastIdSystem_spec.js".
must be failing due to submodules effectively inheriting findRootDomain from the userId module (userId/index.js) and not being available during test time. There are similar errors on lotamePanoramaIdSystem_spec. I could fix the unit test by adding

import {findRootDomain} from 'modules/userId/index.js'

quantcastIdSubmodule["findRootDomain"] = findRootDomain;
sinon.stub(quantcastIdSubmodule, 'findRootDomain');

This, however, wouldn't catch situations where the submodule genuinely couldn't inherit that function. Is there any fix you would suggest?

Also, I see the CircleCI tests failing in another adaptor unrelated to this change. Do you know how I can resolve that?

[ncolletti]

LGTM