-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuantcastId : Add support for firing pixel in quantcastIdSystem submodule #7107
Merged
Merged
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7df1c4b
add code for firing pixel without measure
05ec12c
add more unit tests
8439525
correct gdpr logic; don't fire when no consent
7ba5778
add clientId check
17a4058
address more pr comments
35a9e38
add glvid
b31c0f9
remove et / tzo
7a94f13
rename vars; update ccpa check
22f2532
move to protocol relative url
b03709b
refactor code
09680be
Merge pull request #3 from sachinsurfs/prebid-without-measure_
sachinsurfs 279e959
fix lint error
9200bb0
fix unit test for IE compatibility
ed83b37
Create quantcastIdSystem.md
sachinsurfs bf2571e
address pr comments
16c06a7
Merge branch 'master' of https://github.com/sachinsurfs/Prebid.js
706b135
Update quantcastIdSystem.md
sachinsurfs File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the firePixel callback within the load event be within the else block of the document.readyState? May help to prevent rare cases where both can fire as readyState is marked 'complete' right before the window 'load' event fires.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like you mentioned, it is pretty rare since they ideally must happen at the same time. Regardless, I added an else block to be safe.