Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sirdata RTD Module : bidder specific handling removal #9970

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Sirdata RTD Module : bidder specific handling removal #9970

merged 4 commits into from
Jun 6, 2023

Conversation

nouchy
Copy link
Contributor

@nouchy nouchy commented May 18, 2023

move bidder specific handling to ortb2

Type of change

  • Code style update (formatting, local variables)
  • [X ] Refactoring (no functional changes, no api changes)

Description of change

bidder specific handling removal : use ortb2 instead

@nouchy
bidder specific handling removal
6daebf3 
move bidder specific handling to ortb2
@nouchy
Revert "bidder specific handling removal"
e3f3666 
This reverts commit 6daebf3.
@nouchy
bidder specific handling removal
54515e0 
move bidder specific handling to ortb2
@nouchy nouchy mentioned this pull request May 18, 2023
Closed
@ChrisHuie ChrisHuie self-requested a review May 19, 2023 13:17
@ChrisHuie ChrisHuie self-assigned this May 19, 2023
@ChrisHuie ChrisHuie removed their request for review May 19, 2023 13:17
@ChrisHuie ChrisHuie removed their assignment May 19, 2023
@ChrisHuie ChrisHuie requested a review from dgirardi May 19, 2023 13:17
@ChrisHuie ChrisHuie changed the title Upgrade Sirdata RTD Module : bidder specific handling removal May 19, 2023
dgirardi
dgirardi reviewed May 25, 2023
View reviewed changes
modules/sirdataRtdProvider.js
@@ -370,57 +369,24 @@ export function addSegmentData(reqBids, data, moduleConfig, onDone) {
case 'msq_classic':
case 'msq_max':
case '366_apx':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm missing some context, if the intent of this is to remove bidder-specific handling why is there a giant switch statement for a bunch of bidders?

@nouchy
Copy link
Contributor Author

nouchy commented May 25, 2023 via email

patmmccann
patmmccann reviewed May 25, 2023
View reviewed changes
modules/sirdataRtdProvider.js Outdated
}
let psCurationData = getSegAndCatsArray(data.shared_taxonomy[psCurationId], minScore, null);
sirdataData = applySdaGetSpecificData(data, sirdataData, biddersParamsExist, minScore, reqBids, bid, moduleConfig, indexFound, bidderIndex, adUnit);
let psCurationId = (indexFound && moduleConfig.params.bidders[bidderIndex].hasOwnProperty('curationId') ? moduleConfig.params.bidders[bidderIndex].curationId : (partnerIds[bid.bidder] ? partnerIds[bid.bidder] : null));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this logic into the proxistore adapter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@dgirardi
Copy link
Collaborator

Hello, the idea here is to avoid data shared with bidders directly. First step us to work through ortb2, and when bidders are ready to use SDA… please see this comment : #8596 (comment)

I am not following; is the data different depending on the bidder? if yes, which bidders get which data should be configurable (not based in a switch statement in code); if not, you shouldn't need the switch statement. RTD modules should try to stay as agnostic as possible regarding who gets the data.

@nouchy
Copy link
Contributor Author

nouchy commented May 25, 2023 via email

@nouchy
Copy link
Contributor Author

nouchy commented May 25, 2023 via email

@peczenyj peczenyj mentioned this pull request May 26, 2023
Merged
1 task
@patmmccann
Copy link
Collaborator

@nouchy if proxistore for example isn't moving along, feel free to move your logic specific to them into their adapter.

@nouchy
Copy link
Contributor Author

nouchy commented Jun 2, 2023

@nouchy if proxistore for example isn't moving along, feel free to move your logic specific to them into their adapter.

Sure, I'll do it

@nouchy
bidder specific handling removal
af02777 
move Proxistore spcific logic to bidder
@patmmccann patmmccann merged commit 4d02dd1 into prebid:master Jun 6, 2023
4 checks passed
mscottnelson added a commit to 33Across/Prebid.js that referenced this pull request Jun 15, 2023
@mscottnelson
Merge branch 'master' into 33across_analytics_adapter
be708d9 
* master:
  Colossus Bid Adapter: gpp support (prebid#10096)
  Increment version to 8.1.0-pre
  Prebid 8.0.0 release
  Prebid 8: initial release (prebid#10071)
  Increment version to 7.54.1-pre
  Prebid 7.54.0 release
  Update topicsFpdModule.js (prebid#9990)
  Added GPP support (prebid#10094)
  Teads Bid Adapter:Remove auctionId from since it is not used anymore  (prebid#10098)
  HypeLab Bid Adapter: Initial Release (prebid#10003)
  Oxxion Rtd Module: listen onBidResponseEvent instead of onAuctionEndEvent (prebid#10083)
  PubMatic Analytics Adapter : Added extra fields in tracker for analytics (prebid#10090)
  AdHash Bidder Adapter: update for brand safety (prebid#10087)
  videojsVideoProvider: use contrib-ads event names (prebid#10081)
  Increment version to 7.54.0-pre
  Prebid 7.53.0 release
  Add bidgency alias (prebid#10077)
  Weborama RTD Module : start Bidder specific handling removal (prebid#10005)
  ZetaGlobalSspBidAdapter: change logic around mediaType (prebid#10074)
  add tmax to sovrnBidAdapter (prebid#10059)
  Mediasquare Bid Adapter: Avoid to run bidwon event on video impressions (prebid#10068)
  FreePass User ID Module : initial release (prebid#9814)
  Conceptx Bid Adapter : initial release (prebid#9835)
  beOp BidAdapter: FirstPartyData management and ingest Permutive segments (prebid#9947)
  StroeerCore Bid Adapter: add price floor support (prebid#9962)
  YieldlabBidAdapter updated native asset mapping (prebid#9989)
  Mediasquare Bid Adapter: handle context for video bids (prebid#10055)
  Add new alias - Apester (prebid#10057)
  Criteo Bid Adapter: Pass outstream video renderer method (prebid#10054)
  Add: Viously GVL ID (prebid#10061)
  1plus x RTD Adapter: remove bidder specific handling enforcement (DC 3634) (prebid#10001)
  Sirdata RTD Module : bidder specific handling removal (prebid#9970)
  feat: pass video.plcmt [PB-1736] (prebid#10058)
  Update adkernelBidAdapter.js (prebid#10056)
  Eskimi Bid Adapter: Added support for video (prebid#9985)
  Richaudience Bid Adapter : add compability with GPID (prebid#9928)
  Add GVL ID for pairId userId submodule. (prebid#10053)
  Update nexx360BidAdapter.js (prebid#10042)
  Logicad Bid Adapter: Add topics and uach support (prebid#10045)
  change session_id fallback to bidderRequestId (prebid#10047)
  ZetaGlobalSsp Bid Adapter : process array of sizes (prebid#10039)
  AdagioBidAdapter: change outstream renderer (prebid#10035)
  update greenbids analytics endpoint (prebid#10037)
  ID5 User Id module - get whole ext object from server response (prebid#10036)
  Criteo Bid Adapter : Bump fastbid version to 136 (prebid#9973)
  UID2 & EUID Modules: Add support for EUID and prefer localStorage for both modules. (prebid#9968)
  Schain module: do not share schain objects across different bid requests (prebid#10021)
  airgridRtdProvider: use provided tag insertion method `loadExternalScript` (prebid#9901)
  Increment version to 7.53.0-pre
  Prebid 7.52.0 release
  Yahoo ConnectId - fixed tests. (prebid#10033)
  Core & Multiple modules: activity controls (prebid#9802)
  Yahoo ConnectId - gpp consent module usage. (prebid#10022)
  Yahoo bid adapter:  User sync pixels, consent signals update (prebid#10028)
  Core: fix `markWinningBidAsUsed` to set bid as winning and not just rendered (prebid#10014)
  Adriver Id System: add cfa param to url (prebid#10024)
  Undertone Bid Adapter : added GPP and video placements (prebid#10016)
  Oxxion Analytics Adapter : initial adapter release (prebid#9682)
  Connect id : storage duration updates and no longer require puid or he to be set (prebid#9965)
  Update ad generation adapter 1.6.0: update userSync (prebid#9984)
  fix module type (prebid#10019)
  Stv Bid Adapter: add schain support (prebid#10010)
  GrowthCode RTD  : initial release (prebid#9852)
  ShareThrough Bid Adapter : fix playerSize (prebid#10011)
  chore: update default video placement value [PB-1560] (prebid#9948)
  Smartadserver Bid Adapter: support GPID (prebid#10004)
  Criteo Adapter: Add support of bcat/badv/bapp (prebid#10013)
  Zeta Global SSP Bid Adapter: Added support for video.plcmt (prebid#10009)
  Pair Id System: less noisy errors (prebid#9998)
  Increment version to 7.52.0-pre
  Prebid 7.51.0 release
  Appnexus Bid Adapter: added uol as an alias (prebid#10002)
  Adquery Bid Adapter : added bid request: version and bidPageUrl (prebid#9946)
  MinuteMedia Bid Adapter: support sua and plcmt params (prebid#9997)
  Adkernel Bid Adapter: add didnadisplay alias (prebid#10000)
  Adrino Bid Adapter: pass adUnitCode to adserver (prebid#9993)
musikele pushed a commit to rubicon-project/Prebid.js that referenced this pull request Aug 28, 2023
@nouchy
Sirdata RTD Module : bidder specific handling removal (prebid#9970)
ec3dba3 
* bidder specific handling removal

move bidder specific handling to ortb2

* Revert "bidder specific handling removal"

This reverts commit 6daebf3.

* bidder specific handling removal

move bidder specific handling to ortb2

* bidder specific handling removal

move Proxistore spcific logic to bidder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgirardi dgirardi dgirardi left review comments

@patmmccann patmmccann patmmccann approved these changes

Assignees

@dgirardi dgirardi

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nouchy @dgirardi @patmmccann @ChrisHuie