build(docker): simplify docker build #170
Conversation
Build in to a docker image, rather than build locally
|
hey @johngeorgewright ... I'm actually updating the docs in #167. Would you mind t They work for me... but since I first installed this project a long time ago, I may have done some steps in the past and forgotten about them. I'm not crazy about the production effect of this changeset. The docker container would be much larger, since it needs to contain Go, Glide, source code, etc. Today, we just copy a standalone binary, which is much lighter weight. You can read more about the strategy here: https://blog.codeship.com/building-minimal-docker-containers-for-go-applications/ Could you post any error messages you're getting? I'd definitely like to get to the bottom of it, and make sure that the new docs make it as easy as possible to get started. |
|
So, the difficulties I ran in to were during the build. The version of master that I had was erroring. After installing Go and Glide and not really knowing much about the language, I struggled for a couple of hours putting the build in to Docker. Come to think of it, the way I had got around the problem was by checking out your last tag. I understand that you want to make the build as small as possible, so forget this pull request then. It just made things a lot easier here, as we didn't want to have to build on our development machines to get something live. Have you thought about uploading your images to the docker hub? |
* Url decoding value of keywords * Refactored code to rename dctr to key_val * Added pmzoneid support in keywords * Refactored code with removing single statement function * Refactored code, renaming variables * Refactored code: Removed size argument to make for impExtMap * Added test case for URL encoded dctr value * Added omitempty for fields in ExtImpPubmatic
I was experiencing some difficulties building a docker image from scratch. After some fiddling, I put all your suggested commands directly in to the Dockerfile and all seems to work.