Add ImpIds in RequestData for associated Impressions

[pm-saurabh-narkhede]

Implements #2973

[bsardo]

The approach here looks good. There's still a major effort left though to update the tests which involves explicitly defining what the expected RequestData.ImpIDs are in every adapter's JSON tests via httpCalls[i].expectedRequests.

The team discussed a few possible test solutions and figured we should provide the test framework update we're looking for so that we can be sure we avoid rework.

Please add the following field to httpRequest here (https://github.com/prebid/prebid-server/blob/master/adapters/adapterstest/test_json.go#L203):

ImpIDs  []string        `json:"impIDs"`

If you could then add the following just before the last return statement here (https://github.com/prebid/prebid-server/blob/master/adapters/adapterstest/test_json.go#L321) and update all of the JSON tests accordingly that would be great:

if len(expected.ImpIDs) < 1 {
    return fmt.Errorf(`expected.ImpIDs must contain at least one imp ID`)
}
if !reflect.DeepEqual(expected.ImpIDs, actual.ImpIDs) {
    return fmt.Errorf(`%s actual.ImpIDs "%q" do not match expected "%q"`, description, actual.ImpIDs, expected.ImpIDs)
}

[pm-saurabh-narkhede]

Hello @bsardo,
I shared the same perspective and implemented the changes you requested. Could you kindly review my latest two commits to confirm whether I am heading in the right direction or not?

[bsardo]

@pm-saurabh-narkhede Your approach looks good. I think you can continue with this for the remaining adapters.

[pm-saurabh-narkhede]

Hello @bsardo ,
Can you please specifically check this commit 90a190a
where I have added impIDs for json test files where imp.id not present/given.

[bsardo]

Hello @bsardo , Can you please specifically check this commit 90a190a where I have added impIDs for json test files where imp.id not present/given.

Hi @pm-saurabh-narkhede this commit looks good. Is this ready for review? At first glance it looks like you updated all of the applicable JSON tests.

[pm-saurabh-narkhede]

Hello @bsardo , Can you please specifically check this commit 90a190a where I have added impIDs for json test files where imp.id not present/given.

Hi @pm-saurabh-narkhede this commit looks good. Is this ready for review? At first glance it looks like you updated all of the applicable JSON tests.

Hi @bsardo ,
It is ready to review. All applicable changes are done from my side.

[bsardo]

@pm-saurabh-narkhede no rush, I just want to make sure you saw my couple of other comments requesting changes. Once those are made I will re-review.

[pm-saurabh-narkhede]

@pm-saurabh-narkhede no rush, I just want to make sure you saw my couple of other comments requesting changes. Once those are made I will re-review.

@bsardo I have made the changes. You can review them.

[bretg]

blocks #2852

[hhhjort]

It is a shame that adgeneration does not have any multi-imp tests. But that is beyond the scope of this PR. We will have to try to be more picky about that in adapter reviews.

[pm-saurabh-narkhede]

Agree with you @hhhjort .
Thanks for noticing it out.

[pm-saurabh-narkhede]

Hi @SyntaxNode , @hhhjort , @bsardo ,
@bsardo approval got dismissed because of my new commit. I have merge latest master to my branch and added changes in new json files. Request you Provide inputs/comments/suggestions/approvals earliest as it blocks multiple issues and also new json files will be added. Thank you !

[hhhjort]

LGTM