Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImpIds in RequestData for associated Impressions #3364

Merged
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
2374fb4
provide impId in RequestData
pm-saurabh-narkhede Dec 19, 2023
03e97e0
ImpressionIds in requestData for all adapters
pm-saurabh-narkhede Dec 26, 2023
cd6b177
remove redundunt getImpIds method
pm-saurabh-narkhede Dec 26, 2023
d795029
test for for bidder adf
pm-saurabh-narkhede Jan 3, 2024
7e55e50
Add tests for few Bidders
pm-saurabh-narkhede Jan 8, 2024
6e2c7f9
Add Test Cases for Bidders Start with `a`
pm-saurabh-narkhede Jan 8, 2024
acbe193
Update few more json with `impIDs`
pm-saurabh-narkhede Jan 9, 2024
c40b264
Update json test files and Assert ImpIDs after sorting
pm-saurabh-narkhede Jan 10, 2024
dffae1a
Update few more json test files with `impIDs`
pm-saurabh-narkhede Jan 10, 2024
52a9dae
Update json test files with `impIDs` for remaining adapters
pm-saurabh-narkhede Jan 11, 2024
90a190a
Fix json test cases of some bidders by adding `impid`
pm-saurabh-narkhede Jan 11, 2024
a9f2754
Merge remote-tracking branch 'origin/master' into impid-in-requestDat…
pm-saurabh-narkhede Jan 11, 2024
468f34e
fix test cases for new json test files
pm-saurabh-narkhede Jan 11, 2024
525bea9
Pass all impIDs in the request instead of first
pm-saurabh-narkhede Jan 23, 2024
ab6b373
Merge remote-tracking branch 'upstream/master' into impid-in-requestD…
pm-saurabh-narkhede Jan 23, 2024
c77d249
Fix tests for newly added json files
pm-saurabh-narkhede Jan 23, 2024
2aef44d
Merge remote-tracking branch 'origin/master' into impid-in-requestDat…
pm-saurabh-narkhede Feb 8, 2024
5cc8f64
add impIds in newly added jsons files
pm-saurabh-narkhede Feb 8, 2024
b8badac
update ucfunnel test and pass correct param in `GetImpIDs`
pm-saurabh-narkhede Feb 15, 2024
d5ceb8a
Merge remote-tracking branch 'origin/master' into impid-in-requestDat…
pm-saurabh-narkhede Feb 15, 2024
8ad101a
add `impIDs` in newly added json files
pm-saurabh-narkhede Feb 15, 2024
5e975bb
Fix Typo
pm-saurabh-narkhede Feb 15, 2024
3aa4c80
Merge branch 'master' into impid-in-requestData-for-adapters
pm-saurabh-narkhede Apr 8, 2024
427c487
optimize `GetImpIDs` and add impids in new jsons
pm-saurabh-narkhede Apr 8, 2024
ba08cf5
address latest review comments
pm-saurabh-narkhede Apr 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions adapters/33across/33across.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ func (a *TtxAdapter) makeRequest(request openrtb2.BidRequest, impList []openrtb2
Uri: a.endpoint,
Body: reqJSON,
Headers: headers,
ImpIDs: openrtb_ext.GetImpIDs(impList),
pm-saurabh-narkhede marked this conversation as resolved.
Show resolved Hide resolved
}, nil
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
pm-saurabh-narkhede marked this conversation as resolved.
Show resolved Hide resolved
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/33across/33acrosstest/exemplary/multi-format.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id1","test-imp-id2"]
},
"mockResponse": {
"status": 200,
Expand Down Expand Up @@ -172,7 +173,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id3"]
},
"mockResponse": {
"status": 200,
Expand Down Expand Up @@ -233,7 +235,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id4"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 204
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/33across/33acrosstest/exemplary/site-banner.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/33across/33acrosstest/exemplary/site-video.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id1"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 400,
Expand Down
1 change: 1 addition & 0 deletions adapters/aax/aax.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.E
Uri: a.endpoint,
Body: reqJson,
Headers: headers,
ImpIDs: openrtb_ext.GetImpIDs(request.Imp),
}}, errs
}

Expand Down
3 changes: 2 additions & 1 deletion adapters/aax/aaxtest/exemplary/multi-format.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@
}
}
]
}
},
"impIDs":["1"]
},
"mockResponse": {
"status": 204,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aax/aaxtest/exemplary/multi-imps.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@
}
}
]
}
},
"impIDs":["1","2"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aax/aaxtest/exemplary/no-bid.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
}
}
]
}
},
"impIDs":["1"]
},
"mockResponse": {
"status": 204,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aax/aaxtest/exemplary/optional-params.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@
}
}
]
}
},
"impIDs":["1"]
},
"mockResponse": {
"status": 204,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aax/aaxtest/exemplary/simple-banner.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
}
}
]
}
},
"impIDs":["1"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aax/aaxtest/exemplary/simple-video.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@
}
}
]
}
},
"impIDs":["1"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@
"buyeruid": "0000-000-000-0000"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 400
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@
"gdpr": 0
}
}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@
"gdpr": 0
}
}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@
"gdpr": 0
}
}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@
"id": "imp-id"
}
]
}
},
"impIDs":["imp-id"]
},
"mockResponse": {
"status": 204,
Expand Down
1 change: 1 addition & 0 deletions adapters/aceex/aceex.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ func (a *adapter) MakeRequests(
Body: reqJSON,
Uri: url,
Headers: getHeaders(openRTBRequest),
ImpIDs: []string{openRTBRequest.Imp[0].ID},
pm-saurabh-narkhede marked this conversation as resolved.
Show resolved Hide resolved
}}, nil
}

Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/exemplary/banner-app.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/exemplary/banner-web.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/exemplary/native-app.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/exemplary/native-web.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/exemplary/video-app.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/exemplary/video-web.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/supplemental/invalid-response.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 400
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 204
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 306
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 503
Expand Down
1 change: 1 addition & 0 deletions adapters/acuityads/acuityads.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ func (a *AcuityAdsAdapter) MakeRequests(
Body: reqJSON,
Uri: url,
Headers: getHeaders(openRTBRequest),
ImpIDs: []string{openRTBRequest.Imp[0].ID},
}}, nil
}

Expand Down
3 changes: 2 additions & 1 deletion adapters/acuityads/acuityadstest/exemplary/banner-app.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down