Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: Aso #3565

Merged
merged 7 commits into from
Mar 18, 2024
Merged

New Adapter: Aso #3565

merged 7 commits into from
Mar 18, 2024

Conversation

adserver-online
Copy link
Contributor

Aso server adapter added.

Docs PR: prebid/prebid.github.io#5194

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8d36d30

aso

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/aso/aso.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:35:	MakeRequests		85.2%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:89:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:133:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:138:	getMediaType		100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:152:	resolveMacros		80.0%
total:								(statements)		92.5%

gargcreation1992
gargcreation1992 reviewed Mar 10, 2024
View reviewed changes
static/bidder-info/bidgency.yaml
aliasOf: aso
endpoint: "https://srv.bidgx.com/pbs/bidder?zid={{.ZoneID}}"
maintainer:
email: "aso@bidgency.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sent email for verification. Please reply with received.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They replied, please check your inbox.

gargcreation1992
gargcreation1992 reviewed Mar 12, 2024
View reviewed changes
static/bidder-info/bcmint.yaml
aliasOf: aso
endpoint: "https://srv.datacygnal.io/pbs/bidder?zid={{.ZoneID}}"
maintainer:
email: "contact@bcm.ltd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent email to this address as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They replied, please check your inbox.

gargcreation1992
gargcreation1992 reviewed Mar 12, 2024
View reviewed changes
static/bidder-info/aso.yaml
@@ -0,0 +1,21 @@
endpoint: "https://srv.aso1.net/pbs/bidder?zid={{.ZoneID}}"
maintainer:
email: "support@adsrv.org"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent email to this address as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied.

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f8fb3ef

aso

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/aso/aso.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:35:	MakeRequests		85.2%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:88:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:127:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:132:	getMediaType		100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:146:	resolveMacros		80.0%
total:								(statements)		92.3%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5aac873

aso

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/aso/aso.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:35:	MakeRequests		85.2%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:88:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:126:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:131:	getMediaType		100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:145:	resolveMacros		80.0%
total:								(statements)		92.2%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 868667b

aso

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/aso/aso.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:35:	MakeRequests		85.2%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:88:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:126:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:131:	getMediaType		100.0%
github.com/prebid/prebid-server/v2/adapters/aso/aso.go:145:	resolveMacros		80.0%
total:								(statements)		92.2%

@gargcreation1992 gargcreation1992 merged commit db34155 into prebid:master Mar 18, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@gargcreation1992 gargcreation1992 gargcreation1992 approved these changes

@Sonali-More-Xandr Sonali-More-Xandr Sonali-More-Xandr approved these changes

Assignees

@gargcreation1992 gargcreation1992

@Sonali-More-Xandr Sonali-More-Xandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adserver-online @gargcreation1992 @Sonali-More-Xandr