Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Aso #3565

Merged
merged 7 commits into from
Mar 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 152 additions & 0 deletions adapters/aso/aso.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,152 @@
package aso

import (
"encoding/json"
"fmt"
"net/http"
"strconv"
"strings"
"text/template"

"github.com/prebid/openrtb/v20/openrtb2"
"github.com/prebid/prebid-server/v2/adapters"
"github.com/prebid/prebid-server/v2/config"
"github.com/prebid/prebid-server/v2/errortypes"
"github.com/prebid/prebid-server/v2/macros"
"github.com/prebid/prebid-server/v2/openrtb_ext"
)

type adapter struct {
endpoint *template.Template
}

func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
endpointTemplate, err := template.New("endpointTemplate").Parse(config.Endpoint)
if err != nil {
return nil, fmt.Errorf("unable to parse endpoint template: %v", err)
}

bidder := &adapter{
endpoint: endpointTemplate,
}
return bidder, nil
}

func (a *adapter) MakeRequests(request *openrtb2.BidRequest, requestInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {

var requests []*adapters.RequestData
var errors []error

requestCopy := *request

for _, imp := range request.Imp {
var bidderExt adapters.ExtImpBidder
if err := json.Unmarshal(imp.Ext, &bidderExt); err != nil {
errors = append(errors, &errortypes.BadInput{
Message: fmt.Sprintf("invalid imp.ext, %s", err.Error()),
})
continue
}

var impExt openrtb_ext.ExtImpAso
if err := json.Unmarshal(bidderExt.Bidder, &impExt); err != nil {
errors = append(errors, &errortypes.BadInput{
Message: fmt.Sprintf("invalid bidderExt.Bidder, %s", err.Error()),
})
continue
}

requestCopy.Imp = []openrtb2.Imp{imp}
endpoint, err := a.buildEndpointURL(&impExt)

adserver-online marked this conversation as resolved.
Show resolved Hide resolved
if err != nil {
errors = append(errors, err)
continue
}

reqJSON, err := json.Marshal(requestCopy)
if err != nil {
errors = append(errors, err)
continue
}

headers := http.Header{}
headers.Add("Content-Type", "application/json;charset=utf-8")
headers.Add("Accept", "application/json")

requestData := &adapters.RequestData{
Method: http.MethodPost,
Uri: endpoint,
Body: reqJSON,
Headers: headers,
}
requests = append(requests, requestData)
}
return requests, errors
}

func (a *adapter) MakeBids(request *openrtb2.BidRequest, requestData *adapters.RequestData, responseData *adapters.ResponseData) (*adapters.BidderResponse, []error) {
if adapters.IsResponseStatusCodeNoContent(responseData) {
return nil, nil
}

if err := adapters.CheckResponseStatusCodeForErrors(responseData); err != nil {
return nil, []error{err}
}

var response openrtb2.BidResponse
if err := json.Unmarshal(responseData.Body, &response); err != nil {
return nil, []error{err}
}

bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(request.Imp))
bidResponse.Currency = response.Cur

var errors []error
for _, seatBid := range response.SeatBid {
for i, bid := range seatBid.Bid {
resolveMacros(&seatBid.Bid[i])

bidType, err := getMediaType(bid)
if err != nil {
errors = append(errors, err)
continue
}

bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{
Bid: &seatBid.Bid[i],
BidType: bidType,
})
}
}

return bidResponse, errors
}

func (a *adapter) buildEndpointURL(params *openrtb_ext.ExtImpAso) (string, error) {
endpointParams := macros.EndpointTemplateParams{ZoneID: strconv.Itoa(params.Zone)}
return macros.ResolveMacros(a.endpoint, endpointParams)
}

func getMediaType(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
if bid.Ext != nil {
var bidExt openrtb_ext.ExtBid
err := json.Unmarshal(bid.Ext, &bidExt)
if err == nil && bidExt.Prebid != nil {
return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type))
adserver-online marked this conversation as resolved.
Show resolved Hide resolved
}
}

return "", &errortypes.BadServerResponse{
Message: fmt.Sprintf("Failed to get type of bid \"%s\"", bid.ImpID),
}
}

func resolveMacros(bid *openrtb2.Bid) {
if bid == nil {
return
}
price := strconv.FormatFloat(bid.Price, 'f', -1, 64)
bid.NURL = strings.Replace(bid.NURL, "${AUCTION_PRICE}", price, -1)
bid.AdM = strings.Replace(bid.AdM, "${AUCTION_PRICE}", price, -1)
}
28 changes: 28 additions & 0 deletions adapters/aso/aso_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
package aso

import (
"github.com/stretchr/testify/assert"
"testing"

"github.com/prebid/prebid-server/v2/adapters/adapterstest"
"github.com/prebid/prebid-server/v2/config"
"github.com/prebid/prebid-server/v2/openrtb_ext"
)

func TestJsonSamples(t *testing.T) {
bidder, buildErr := Builder(openrtb_ext.BidderAso, config.Adapter{
Endpoint: "https://srv.aso1.net/pbs/bidder?zid={{.ZoneID}}"}, config.Server{ExternalUrl: "http://hosturl.com"})

if buildErr != nil {
t.Fatalf("Builder returned unexpected error %v", buildErr)
}

adapterstest.RunJSONBidderTest(t, "asotest", bidder)
}

func TestEndpointTemplateMalformed(t *testing.T) {
_, buildErr := Builder(openrtb_ext.BidderAso, config.Adapter{
Endpoint: "zid={{ZoneID}}"}, config.Server{ExternalUrl: "http://hosturl.com"})

assert.Error(t, buildErr)
}
125 changes: 125 additions & 0 deletions adapters/aso/asotest/exemplary/app-banner.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
{
"mockBidRequest": {
"id": "test-request-id",
"app": {
"bundle": "com.prebid"
},
"device": {
"ip":"127.0.0.1"
},
"imp": [
{
"id": "test-imp-id",
"banner": {
"format": [
{
"w": 300,
"h": 50
}
]
},
"ext": {
"bidder": {
"zone": 123456
}
}
}
]
},

"httpCalls": [
{
"expectedRequest": {
"uri": "https://srv.aso1.net/pbs/bidder?zid=123456",
"headers": {
"Accept": [
"application/json"
],
"Content-Type": [
"application/json;charset=utf-8"
]
},
"body": {
"id": "test-request-id",
"app": {
"bundle": "com.prebid"
},
"device": {
"ip":"127.0.0.1"
},
"imp": [
{
"id": "test-imp-id",
"banner": {
"format": [
{
"w": 300,
"h": 50
}
]
},
"ext": {
"bidder": {
"zone": 123456
}
}
}
]
}
},
"mockResponse": {
"status": 200,
"body": {
"id": "test-request-id",
"seatbid": [
{
"seat": "seat",
"bid": [
{
"id": "1",
"impid": "test-imp-id",
"price": 0.500000,
"adm": "html code",
"crid": "123",
"h": 50,
"w": 300,
"ext": {
"prebid": {
"type": "banner"
}
}
}
]
}
],
"cur": "USD"
}
}
}
],

"expectedBidResponses": [
{
"currency": "USD",
"bids": [
{
"bid": {
"id": "1",
"impid": "test-imp-id",
"price": 0.5,
"adm": "html code",
"crid": "123",
"w": 300,
"h": 50,
"ext": {
"prebid": {
"type": "banner"
}
}
},
"type": "banner"
}
]
}
]
}
Loading
Loading