Refine PBS activity attributes #5106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
the code doesn't do this yet, so please don't merge the docs yet |
marki1an
reviewed
Apr 17, 2024
Co-authored-by: Markiyan Mykush <95693607+marki1an@users.noreply.github.com>
|
Thanks @marki1an - I'd forgotten about this old PR. It's got conflicts now. Will fix... |
|
added a note about which version does this, so going ahead with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in prebid/prebid-server#3304
Spoke with Prebid's legal counsel. She agreed that Prebid Server could reasonably preserve device.geo.country and device.geo.region.