Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate getMeshVertexIDsFromPositions and getMeshVertices? #1248

Closed
BenjaminRodenberg opened this issue Apr 19, 2022 · 8 comments · Fixed by #1556
Closed

Deprecate getMeshVertexIDsFromPositions and getMeshVertices? #1248

BenjaminRodenberg opened this issue Apr 19, 2022 · 8 comments · Fixed by #1556
Assignees
@mardom1
Labels
good first issue Everybody is invited to help: students, users, externals, ... maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain. usability This issue will make preCICE easier for non-expert users
Milestone
Version 3.0.0

Comments

@BenjaminRodenberg
Copy link
Member

Is the function SolverInterface::getMeshVertexIDsFromPositions needed? I have never used it and it would be a candidate for deletion for v3.0.0 from my perspective.

There was some discussion about this API function in #374, but besides this it looks mostly unused. As far as I see it there are also no tests for this function.
@BenjaminRodenberg BenjaminRodenberg added usability This issue will make preCICE easier for non-expert users maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain. labels Apr 19, 2022
@BenjaminRodenberg BenjaminRodenberg added this to the Version 2.4.0 milestone Apr 19, 2022
@BenjaminRodenberg
Copy link
Member Author

I realized that the same is true for getMeshVertices 🙈

@BenjaminRodenberg BenjaminRodenberg changed the title Deprecate getMeshVertexIDsFromPositions? Deprecate getMeshVertexIDsFromPositions and getMeshVertices? Apr 20, 2022
@BenjaminRodenberg BenjaminRodenberg mentioned this issue Apr 20, 2022
Closed
@davidscn
Copy link
Member

We use getMeshVerticesFromPositions in the openfoam-adapter in order to define connectivity.

@uekerman uekerman modified the milestones: Version 2.4.0, Version 2.x.x Apr 25, 2022
@precice-bot
Copy link

This issue has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/highlights-of-the-new-precice-release-v2-4/1047/1

@fsimonis fsimonis modified the milestones: Version 2.x.x, Version 3.0.0 Nov 14, 2022
@fsimonis
Copy link
Member

We decided to remove it.

@fsimonis fsimonis added the good first issue Everybody is invited to help: students, users, externals, ... label Nov 15, 2022
@IshaanDesai IshaanDesai mentioned this issue Nov 15, 2022
Closed
@davidscn davidscn mentioned this issue Nov 15, 2022
Closed
@IshaanDesai IshaanDesai mentioned this issue Nov 16, 2022
Closed
@uekerman
Copy link
Member

IMO getMeshVertices could be removed as well. I don't see a use case.

@fsimonis
Copy link
Member

FYI we are extending the docs to clarify what to do.

@mardom1
Copy link
Contributor

mardom1 commented Jan 27, 2023

I am interested in working on this. Did I understand correctly that they should be directly removed not deprecated?

@IshaanDesai
Copy link
Member

I am interested in working on this. Did I understand correctly that they should be directly removed not deprecated?

Decision is to remove the functions and not just deprecate them.

mardom1 added a commit to mardom1/precice that referenced this issue Jan 30, 2023
@mardom1
Remove getMeshVertexIDsFromPositions and getMeshVertices
3198770 
see precice#1248
@mardom1 mardom1 mentioned this issue Jan 30, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mardom1 mardom1

Labels
good first issue Everybody is invited to help: students, users, externals, ... maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain. usability This issue will make preCICE easier for non-expert users
Projects
None yet
Milestone
Version 3.0.0
Development

Successfully merging a pull request may close this issue.

Remove getMeshVertexIDsFromPositions and getMeshVertices mardom1/precice
7 participants
@uekerman @BenjaminRodenberg @fsimonis @mardom1 @davidscn @precice-bot @IshaanDesai