Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: write data when subcycling is used (outdated) #1523

Conversation

BenjaminRodenberg
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg commented Dec 22, 2022

Main changes of this PR

Allows to write data to preCICE when subcycling is used. This either results in a piecewise constant or linear interpolation. Possibly also in higher-order interpolation.

Motivation and additional information

See #1171

This is a rebased version of #1414, based on #1520.

Author's checklist

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@BenjaminRodenberg
Copy link
Member Author

All tests are working now. The main restrictions is that actions (and corresponding tests) have been removed in 91d76c6. I think the implementation of actions needs a proper redesign. We should redesign the actions independent from this PR (e.g. in #1504).

Additionally, there is a ton of unmerged PRs that this PR depends on (see PR description). But: The main feature of this PR is working and it is synchronized with the current state of develop (ec46919).

BenjaminRodenberg added a commit to BenjaminRodenberg/precice that referenced this pull request May 21, 2023
@BenjaminRodenberg BenjaminRodenberg changed the title WIP: write data when subcycling is used WIP: write data when subcycling is used (outdated) May 27, 2023
@BenjaminRodenberg
Copy link
Member Author

This PR is replaced by an updated version (#1671).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature, a new functionality of preCICE (from user perspective)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants