New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename all instances of words master and slave #1253
Rename all instances of words master and slave #1253
Conversation
…into rename-master-slave
…imariessecondary'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some work to do here 😁
Simple brute-force replacements do not work here as IMO "pimary" and "secondary" should only be used as adjectives (at least in comments).
Some common suggestions:
- "to the primary ..." -> "to the primary rank ..."
- "secondaries" -> "secondary ranks"
- "primary-primary com" -> "primary com"
- "master-slave mode": as the server mode does no longer exist, we can just drop these
- "on all slaves" or similar -> "on all ranks" as typically this also happens on the (previous) master rank
I hope I caught all occasions. See also the suggestions here: #1026 (comment)
In which order do you plan to merge this PR and #1255 ?
You will get nasty merge conflicts. It could be better start #1255 from scratch again.
…into rename-master-slave
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not go through everything again. Still open TODOs. Sorry 😁
I would advice against any "find and replace" here. Then, we end up with names like acceptSecondaryRanksConnection
where acceptSecondaryConnections
feels much more natural.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did look through the details again, but I have a good feeling.
Main changes of this PR
Renaming all instances of words master and slave to primary and secondary or similar to this. Changes to names of variables are done according to the relevance of their use and the functionality of the class. This PR also renamer the words Master and Slave (with capital letters) in most places. The file
MasterSlave.cpp
and its use in other files is not changed as this would mask the changes done inside the file itself. The file name change is handled in: #1255Motivation and additional information
We need to do this because we are in the 21st century ✊
Author's checklist
make changelog
if there are user-observable changes since the last release.make format
to ensure everything is formatted correctly.Reviewers' checklist