Add linear cell interpolation mapping for 2D #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Last comment from my side is that the name should be |
fsimonis
reviewed
May 23, 2022
src/query/Index.cpp
Outdated
| @@ -211,6 +211,25 @@ ProjectionMatch Index::findNearestProjection(const Eigen::VectorXd &location, in | |||
| } | |||
| } | |||
|
|
|||
| ProjectionMatch Index::findCellInterpolation(const Eigen::VectorXd &location, int n) | |||
There was a problem hiding this comment.
We are now falling back to nearest-projection by design. So this name is very misleading.
It could also be findCellOrProjection, but the name has to change.
tests/parallel/mapping-volume/testParallelSquareConservative1To2.cpp
Outdated
Show resolved
Hide resolved
tests/parallel/mapping-volume/testParallelTriangleConservative2To1.cpp
Outdated
Show resolved
Hide resolved
uekerman
requested changes
May 25, 2022
Co-authored-by: Benjamin Uekermann <benjamin.uekermann@gmail.com>
|
@uekerman all done except the unresolved conversation above. |
fsimonis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
volume-cell-interpolationin the XML config and set up connectivitiy.Motivation and additional information
Milestone of #468.
Followup of #1258
Author's checklist
make changelogif there are user-observable changes since the last release.make formatto ensure everything is formatted correctly.Reviewers' checklist
@fsimonis : there is still the fall-back question to answer.
For now, we fall-back in NN when the vertex isn't inside a good triangle. However fall-back on edge could be useful in some edge cases (no pun intended).
If we consider the triangle formed by (0,0), (1,0) (0,1) and a point on (-eps, 0.5) with eps a small number, we clearly want to interpolate linearly in the edge. However it is not in the triangle thus falls back to NN