New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertex-only primitives #1311
Merged
Merged
Vertex-only primitives #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
uekerman
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not look at every detail, but I think I understand the changes and the reasoning 👍
It also simplifies handling triangles in tests.
which is not yet part of this PR, right?
fsimonis
force-pushed
the
vertex-only-primitives
branch
from
June 15, 2022 09:54
55d8a76
to
dbb9396
Compare
@uekerman no, this will require changing many tests. |
fsimonis
force-pushed
the
vertex-only-primitives
branch
from
June 15, 2022 11:59
dbb9396
to
0d14a1f
Compare
fsimonis
force-pushed
the
vertex-only-primitives
branch
from
June 15, 2022 12:02
0d14a1f
to
001f4bb
Compare
fsimonis
added
the
maintainability
Working on this will make our lives easier in the long run as preCICE gets easier to maintain.
label
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintainability
Working on this will make our lives easier in the long run as preCICE gets easier to maintain.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
This PR simplifies triangles, by defining them in terms of vertices instead of edges.
This reduces their size in memory and avoids having to remap edge IDs in filter and communication operations.
It also simplifies handling triangles in tests.
The change is internal only and has no observable side effects in the API.
Major change is that triangles can now exist independent of edges.
In short:
Motivation and additional information
See #1153
Author's checklist
make changelog
if there are user-observable changes since the last release.make format
to ensure everything is formatted correctly.Reviewers' checklist