Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertex-only primitives #1311

Merged
merged 7 commits into from Jun 15, 2022
Merged

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Jun 2, 2022

Main changes of this PR

This PR simplifies triangles, by defining them in terms of vertices instead of edges.
This reduces their size in memory and avoids having to remap edge IDs in filter and communication operations.
It also simplifies handling triangles in tests.
The change is internal only and has no observable side effects in the API.

Major change is that triangles can now exist independent of edges.

In short:

  • No breaking change
  • lower memory footprint
  • less communication while sending meshes
  • faster filtering and sending of meshes
  • A triangle ABC doesn't imply the existence of edges AB, BC, and AC any longer.

Motivation and additional information

See #1153

Author's checklist

  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I ran make format to ensure everything is formatted correctly.
  • I sticked to C++14 features.
  • I sticked to CMake version 3.16.3.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look at every detail, but I think I understand the changes and the reasoning 👍

It also simplifies handling triangles in tests.

which is not yet part of this PR, right?

src/mesh/Triangle.cpp Show resolved Hide resolved
src/com/CommunicateMesh.cpp Outdated Show resolved Hide resolved
src/com/CommunicateMesh.cpp Outdated Show resolved Hide resolved
@fsimonis
Copy link
Member Author

which is not yet part of this PR, right?

@uekerman no, this will require changing many tests.

@fsimonis fsimonis merged commit b526dc9 into precice:develop Jun 15, 2022
@fsimonis fsimonis deleted the vertex-only-primitives branch June 15, 2022 12:39
@fsimonis fsimonis added the maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain. label Jun 15, 2022
@fsimonis fsimonis added this to the Version 2.x.x milestone Jun 15, 2022
@uekerman uekerman modified the milestones: Version 2.x.x, Version 2.5.0 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants