Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default interface for BSD flavors #1332

Merged
merged 2 commits into from Jun 25, 2022
Merged

Add default interface for BSD flavors #1332

merged 2 commits into from Jun 25, 2022

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Jun 21, 2022 •
edited

Main changes of this PR

This PR adds lo0 as the default network interface for BSD flavoured OSes.

Motivation and additional information

Related to #1331

Author's checklist

  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I ran make format to ensure everything is formatted correctly.
  • I sticked to C++14 features.
  • I sticked to CMake version 3.16.3.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@fsimonis fsimonis added the bug preCICE does not behave the way we want and we should look into it (and fix it if possible) label Jun 21, 2022
@fsimonis fsimonis added this to the Version 2.x.x milestone Jun 21, 2022
@fsimonis fsimonis mentioned this pull request Jun 21, 2022
Open
@fsimonis fsimonis marked this pull request as ready for review June 25, 2022 15:48
@fsimonis fsimonis merged commit 572c036 into develop Jun 25, 2022
@fsimonis fsimonis deleted the add-freebsd-loobback branch June 25, 2022 15:48
davidscn pushed a commit to davidscn/precice that referenced this pull request Jun 30, 2022
@fsimonis @davidscn
Add default interface for BSD flavors (precice#1332)
51cbb7c
@uekerman uekerman modified the milestones: Version 2.x.x, Version 2.5.0 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fsimonis fsimonis

Labels
bug preCICE does not behave the way we want and we should look into it (and fix it if possible)
Projects
None yet
Milestone
Version 2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fsimonis @uekerman