Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable precice-tools building #1344

Merged
merged 1 commit into from Jun 29, 2022

Conversation

davidscn
Copy link
Member

@davidscn davidscn commented Jun 28, 2022

Main changes of this PR

Introduces a cmake option to disable the building of precice-tools

Motivation and additional information

Building them might be undesired. The default flag (ON) delivers fully backward compatibility.

Author's checklist

  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I ran make format to ensure everything is formatted correctly.
  • I sticked to C++14 features.
  • I sticked to CMake version 3.16.3.
  • I squashed / am about to squash all commits that should be seen as one.
  • Check handling of install targets

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@fsimonis
Copy link
Member

fsimonis commented Jun 28, 2022

Is there any reason not to build it? Is has no additional dependencies and takes about a second to compile and link.

A user can always selectively compile libprecice using make precice.

@davidscn
Copy link
Member Author

Is there any reason not to build it? Is has no additional dependencies and takes about a second to compile and link.
A user can always selectively compile libprecice using make precice.

Open for discussion, of course. I was not aware of a make precice option and I thought this is useful in case you develop and don't like to build precice-tools all the time. Makis was also asking today for this, which gave me the final decision to add something like this.

Copy link
Member

@fsimonis fsimonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, it could come in handy in case the sym linking doesn't work or similar. So let's keep it.

@fsimonis fsimonis added the building Improves or extends the building or packaging of preCICE label Jun 29, 2022
@fsimonis fsimonis added this to the Version 2.x.x milestone Jun 29, 2022
@fsimonis fsimonis merged commit 14dd039 into precice:develop Jun 29, 2022
@fsimonis
Copy link
Member

I don't think this will need a changelog

@davidscn davidscn deleted the config-tools branch June 29, 2022 10:25
@uekerman uekerman modified the milestones: Version 2.x.x, Version 2.5.0 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Improves or extends the building or packaging of preCICE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants