Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using volume primitives in Watchpoint if available #1361

Merged
merged 5 commits into from Jul 28, 2022

Conversation

boris-martin
Copy link
Contributor

@boris-martin boris-martin commented Jul 7, 2022

Main changes of this PR

If a Watchpoint watches a point inside the domain, it interpolates on the cell instead of looking for a projection on a boundary element. If there is none (no 2D triangle or no 3D tetra), fall-back to previous behavior, * à la* Nearest-Projection

Motivation and additional information

More accurate watchpoint when used in volumetric coupling

Author's checklist

  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I ran make format to ensure everything is formatted correctly.
  • I sticked to C++14 features.
  • I sticked to CMake version 3.16.3.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@fsimonis
Copy link
Member

fsimonis commented Jul 7, 2022

Could you add a parallel test where rank 1 finds a tetrahedron and rank 0 finds a triangle?

The coordination and ownership has to be correct in parallel cases too and we should explicitly test for that.

@uekerman uekerman added this to the Version 2.5.0 milestone Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants