Set end datetime ranges to 23:59:59 on the same day #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing a date to a DateTimeType range filter, we used to set the time to midnight for both the start and the end range filters. So the following search parameters `start__gte='2019-12-25', start__lte='2019-12-25'` would be converted in the sdk to `'start.gte': '2016-12-25T00:00:00.000000', 'start.lte': '2016-12-25T00:00:00.000000'` This would exclude an event with the following start value `'start': '2016-12-25T05:00:00.000000' This commits sets the end filters (lt, lte) to the datetime max for the day, i.e., `23:59:59.999999`. So the parameters mentioned above would now get converted to `'start.gte': '2016-12-25T00:00:00.000000', 'start.lte': '2016-12-25T23:59:59.999999'` and would include the event mentioned above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a date to a DateTimeType range filter, we used to set the time to midnight for both the start and the end range filters. So the following search parameters
start__gte='2019-12-25', start__lte='2019-12-25'would be converted in the sdk to
'start.gte': '2016-12-25T00:00:00.000000', 'start.lte': '2016-12-25T00:00:00.000000'This would exclude an event with the following start value
'start': '2016-12-25T05:00:00.000000'This commits sets the end filters (
lt,lte) to the datetime max for the day, i.e.,23:59:59.999999. So the parameters mentioned above would now get converted to'start.gte': '2016-12-25T00:00:00.000000', 'start.lte': '2016-12-25T23:59:59.999999'and would include the event mentioned above.