Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#810 added generics to
Client
, that means that when usingClient
you should specify both parameters, getting this kind of message using static analysis tools:Looking at what
Client::getIterator()
does:predis/src/Client.php
Lines 523 to 539 in fbf2701
it returns an
\ArrayIterator
having as keys strings and as values instances of the class itself, so I think this class shouldn't be generic.