fix null password config #436
Conversation
|
The problem with this change is that Considering that an empty connection parameter (I mean where value is $parameters = array_filter($parameters ?: array()), function ($value) {
return $value !== null && $value !== '';
});This fix could also be pushed to a patch release of Predis v1.1 I guess, it doesn't change anything in terms of API after all and I don't see why anyone could have a reason or use case to rely on the current behaviour. I'll open a PR against the |
Having NULL values or zero-length strings for connection parameters does not make much sense and actually it proved to be an issue with certain parameters like "password" where an empty string would trigger an AUTH command with an empty password (and obviously Redis was not happy with that). The main offenders were a few libraries and frameworks that kept passing empty values for parameters such as "database" and "password" even when users left them unconfigured. This fix should make things more robust and avoid such occurrences in the future. Related to PR #436 (rejected).
NULL or zero-length string values passed to "password" and "database" in the connection parameters list do not trigger spurious AUTH and SELECT commands anymore when connecting to Redis. Fixes #436.
|
Fixed for v1.1 in 31baa9b. |
fix null password config