Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autolayout] Bug with cycles and delays having mutual getter/setter #128

Closed
ahonorat opened this issue Apr 5, 2019 · 1 comment · Fixed by #233
Closed

[Autolayout] Bug with cycles and delays having mutual getter/setter #128

ahonorat opened this issue Apr 5, 2019 · 1 comment · Fixed by #233
Labels

Comments

@ahonorat
Copy link
Contributor

ahonorat commented Apr 5, 2019

The autolayout throws an error when generating the diagram corresponding to the attached .pi.
BugAutoLayoutDelay_issue128.zip
In this tricky example, two actor forms a cycle: A0 <-> A0_bis. On both edges, there is a delay whose getter and setter are the delay on the other edge.

The error is generated by the method layoutFifos in the class AutoLayoutFeature. When fixing this bug, the new class HeuristicLoopBreakingDelays should be used instead of the classFifoCycleDetector in order to break cycles.

@antoine-morvan
Copy link
Member

See also #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants